* [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD
@ 2014-09-26 16:14 Roger Pau Monne
2014-09-26 18:07 ` Konrad Rzeszutek Wilk
2014-09-29 10:13 ` Wei Liu
0 siblings, 2 replies; 8+ messages in thread
From: Roger Pau Monne @ 2014-09-26 16:14 UTC (permalink / raw)
To: xen-devel
Cc: Wei Liu, Ian Campbell, Stefano Stabellini, Ian Jackson,
Roger Pau Monne
FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
is all done on the hotplug script like Linux.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
I request a code freeze exception on the basis that this is a bugfix and it
doesn't change the behaviour on platforms different than FreeBSD.
---
tools/libxl/libxl_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index fbc82fd..0018113 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -21,7 +21,7 @@
static const char *libxl_tapif_script(libxl__gc *gc)
{
-#ifdef __linux__
+#if defined(__linux__) || defined(__FreeBSD__)
return libxl__strdup(gc, "no");
#else
return libxl__sprintf(gc, "%s/qemu-ifup", libxl__xen_script_dir_path());
--
1.9.3 (Apple Git-50)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD
2014-09-26 16:14 [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD Roger Pau Monne
@ 2014-09-26 18:07 ` Konrad Rzeszutek Wilk
2014-09-29 13:35 ` Ian Campbell
2014-09-29 10:13 ` Wei Liu
1 sibling, 1 reply; 8+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-09-26 18:07 UTC (permalink / raw)
To: Roger Pau Monne
Cc: xen-devel, Wei Liu, Ian Jackson, Ian Campbell, Stefano Stabellini
On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
> is all done on the hotplug script like Linux.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> I request a code freeze exception on the basis that this is a bugfix and it
> doesn't change the behaviour on platforms different than FreeBSD.
<nods>
Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> tools/libxl/libxl_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index fbc82fd..0018113 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -21,7 +21,7 @@
>
> static const char *libxl_tapif_script(libxl__gc *gc)
> {
> -#ifdef __linux__
> +#if defined(__linux__) || defined(__FreeBSD__)
> return libxl__strdup(gc, "no");
> #else
> return libxl__sprintf(gc, "%s/qemu-ifup", libxl__xen_script_dir_path());
> --
> 1.9.3 (Apple Git-50)
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD
2014-09-26 18:07 ` Konrad Rzeszutek Wilk
@ 2014-09-29 13:35 ` Ian Campbell
2014-09-29 14:05 ` Roger Pau Monné
0 siblings, 1 reply; 8+ messages in thread
From: Ian Campbell @ 2014-09-29 13:35 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: xen-devel, Stefano Stabellini, Ian Jackson, Wei Liu,
Roger Pau Monne
On Fri, 2014-09-26 at 14:07 -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
> > FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
> > is all done on the hotplug script like Linux.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > ---
> > I request a code freeze exception on the basis that this is a bugfix and it
> > doesn't change the behaviour on platforms different than FreeBSD.
>
> <nods>
>
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Applied.
I'm wondering if anyone should be using qemu-ifup these days?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD
2014-09-29 13:35 ` Ian Campbell
@ 2014-09-29 14:05 ` Roger Pau Monné
2014-09-29 15:37 ` Ian Campbell
0 siblings, 1 reply; 8+ messages in thread
From: Roger Pau Monné @ 2014-09-29 14:05 UTC (permalink / raw)
To: Ian Campbell, Konrad Rzeszutek Wilk
Cc: xen-devel, Ian Jackson, Wei Liu, Stefano Stabellini
El 29/09/14 a les 15.35, Ian Campbell ha escrit:
> On Fri, 2014-09-26 at 14:07 -0400, Konrad Rzeszutek Wilk wrote:
>> On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
>>> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
>>> is all done on the hotplug script like Linux.
>>>
>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>> Cc: Ian Campbell <ian.campbell@citrix.com>
>>> Cc: Wei Liu <wei.liu2@citrix.com>
>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>> ---
>>> I request a code freeze exception on the basis that this is a bugfix and it
>>> doesn't change the behaviour on platforms different than FreeBSD.
>>
>> <nods>
>>
>> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Applied.
>
> I'm wondering if anyone should be using qemu-ifup these days?
AFAIR, NetBSD uses it for qemu-trad at least. I was tempted to invert
the ifdef and do something like:
#ifdef __NetBSD__
... use qemu-ifup
#else
... no ifup script
#endif
But I have no idea what Solaris does, or if we still try to support it.
Anyway, thanks for applying this.
Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD
2014-09-29 14:05 ` Roger Pau Monné
@ 2014-09-29 15:37 ` Ian Campbell
2014-09-29 15:45 ` Roger Pau Monné
0 siblings, 1 reply; 8+ messages in thread
From: Ian Campbell @ 2014-09-29 15:37 UTC (permalink / raw)
To: Roger Pau Monné; +Cc: xen-devel, Stefano Stabellini, Ian Jackson, Wei Liu
On Mon, 2014-09-29 at 16:05 +0200, Roger Pau Monné wrote:
> El 29/09/14 a les 15.35, Ian Campbell ha escrit:
> > On Fri, 2014-09-26 at 14:07 -0400, Konrad Rzeszutek Wilk wrote:
> >> On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
> >>> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
> >>> is all done on the hotplug script like Linux.
> >>>
> >>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> >>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >>> Cc: Ian Campbell <ian.campbell@citrix.com>
> >>> Cc: Wei Liu <wei.liu2@citrix.com>
> >>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>> ---
> >>> I request a code freeze exception on the basis that this is a bugfix and it
> >>> doesn't change the behaviour on platforms different than FreeBSD.
> >>
> >> <nods>
> >>
> >> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >
> > Applied.
> >
> > I'm wondering if anyone should be using qemu-ifup these days?
>
> AFAIR, NetBSD uses it for qemu-trad at least. I was tempted to invert
> the ifdef and do something like:
>
> #ifdef __NetBSD__
> ... use qemu-ifup
> #else
> ... no ifup script
> #endif
>
> But I have no idea what Solaris does, or if we still try to support it.
Do we/libxl not call the scripts too in those cases?
> Anyway, thanks for applying this.
NP.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD
2014-09-29 15:37 ` Ian Campbell
@ 2014-09-29 15:45 ` Roger Pau Monné
2014-09-29 15:51 ` Ian Campbell
0 siblings, 1 reply; 8+ messages in thread
From: Roger Pau Monné @ 2014-09-29 15:45 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, Stefano Stabellini, Ian Jackson, Wei Liu
El 29/09/14 a les 17.37, Ian Campbell ha escrit:
> On Mon, 2014-09-29 at 16:05 +0200, Roger Pau Monné wrote:
>> El 29/09/14 a les 15.35, Ian Campbell ha escrit:
>>> On Fri, 2014-09-26 at 14:07 -0400, Konrad Rzeszutek Wilk wrote:
>>>> On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
>>>>> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
>>>>> is all done on the hotplug script like Linux.
>>>>>
>>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>>>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>>>>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>>>> Cc: Ian Campbell <ian.campbell@citrix.com>
>>>>> Cc: Wei Liu <wei.liu2@citrix.com>
>>>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>>> ---
>>>>> I request a code freeze exception on the basis that this is a bugfix and it
>>>>> doesn't change the behaviour on platforms different than FreeBSD.
>>>>
>>>> <nods>
>>>>
>>>> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>
>>> Applied.
>>>
>>> I'm wondering if anyone should be using qemu-ifup these days?
>>
>> AFAIR, NetBSD uses it for qemu-trad at least. I was tempted to invert
>> the ifdef and do something like:
>>
>> #ifdef __NetBSD__
>> ... use qemu-ifup
>> #else
>> ... no ifup script
>> #endif
>>
>> But I have no idea what Solaris does, or if we still try to support it.
>
> Do we/libxl not call the scripts too in those cases?
Yes, the vif hotplug script is also called, but on NetBSD it just takes
care of adding the vif, not the tap interface.
I think it's done this way on NetBSD because tap interfaces cannot be
renamed, so only Qemu knows the actual unit/name of the tap interface
and calls the qemu-ifup script passing that name as the first argument.
Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD
2014-09-29 15:45 ` Roger Pau Monné
@ 2014-09-29 15:51 ` Ian Campbell
0 siblings, 0 replies; 8+ messages in thread
From: Ian Campbell @ 2014-09-29 15:51 UTC (permalink / raw)
To: Roger Pau Monné; +Cc: xen-devel, Ian Jackson, Wei Liu, Stefano Stabellini
On Mon, 2014-09-29 at 17:45 +0200, Roger Pau Monné wrote:
> El 29/09/14 a les 17.37, Ian Campbell ha escrit:
> > On Mon, 2014-09-29 at 16:05 +0200, Roger Pau Monné wrote:
> >> El 29/09/14 a les 15.35, Ian Campbell ha escrit:
> >>> On Fri, 2014-09-26 at 14:07 -0400, Konrad Rzeszutek Wilk wrote:
> >>>> On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
> >>>>> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
> >>>>> is all done on the hotplug script like Linux.
> >>>>>
> >>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>>>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> >>>>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >>>>> Cc: Ian Campbell <ian.campbell@citrix.com>
> >>>>> Cc: Wei Liu <wei.liu2@citrix.com>
> >>>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>>>> ---
> >>>>> I request a code freeze exception on the basis that this is a bugfix and it
> >>>>> doesn't change the behaviour on platforms different than FreeBSD.
> >>>>
> >>>> <nods>
> >>>>
> >>>> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>>
> >>> Applied.
> >>>
> >>> I'm wondering if anyone should be using qemu-ifup these days?
> >>
> >> AFAIR, NetBSD uses it for qemu-trad at least. I was tempted to invert
> >> the ifdef and do something like:
> >>
> >> #ifdef __NetBSD__
> >> ... use qemu-ifup
> >> #else
> >> ... no ifup script
> >> #endif
> >>
> >> But I have no idea what Solaris does, or if we still try to support it.
> >
> > Do we/libxl not call the scripts too in those cases?
>
> Yes, the vif hotplug script is also called, but on NetBSD it just takes
> care of adding the vif, not the tap interface.
>
> I think it's done this way on NetBSD because tap interfaces cannot be
> renamed, so only Qemu knows the actual unit/name of the tap interface
> and calls the qemu-ifup script passing that name as the first argument.
OK.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD
2014-09-26 16:14 [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD Roger Pau Monne
2014-09-26 18:07 ` Konrad Rzeszutek Wilk
@ 2014-09-29 10:13 ` Wei Liu
1 sibling, 0 replies; 8+ messages in thread
From: Wei Liu @ 2014-09-29 10:13 UTC (permalink / raw)
To: Roger Pau Monne
Cc: Wei Liu, Ian Campbell, Stefano Stabellini, Ian Jackson, xen-devel
On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
> is all done on the hotplug script like Linux.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-09-29 15:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-26 16:14 [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD Roger Pau Monne
2014-09-26 18:07 ` Konrad Rzeszutek Wilk
2014-09-29 13:35 ` Ian Campbell
2014-09-29 14:05 ` Roger Pau Monné
2014-09-29 15:37 ` Ian Campbell
2014-09-29 15:45 ` Roger Pau Monné
2014-09-29 15:51 ` Ian Campbell
2014-09-29 10:13 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).