From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 01/28] Neutralize make uninstall
Date: Mon, 29 Sep 2014 14:49:49 +0100
Message-ID: <1411998589.3801.20.camel@citrix.com>
References: <1411658423-18877-1-git-send-email-olaf@aepfle.de>
	<1411658423-18877-2-git-send-email-olaf@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1411658423-18877-2-git-send-email-olaf@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-09-25 at 17:19 +0200, Olaf Hering wrote:
> The uninstall target does not know about the paths it removes because
> the toplevel Makefile does not include the required files.
> 
> Remove all dangerous commands.

Of these only "rm -f $(D)$(XEN_RUN_DIR)*" seems especially dangerous. 

The rest will remove things like /*.conf and /xendomains which is
bad/wrong but not usually catastrophic 

>  There is no replacement.

Yet? Will this be replaced by additions to the appropriate submake files
in the course of this series?
 
> The proper fix is to remove the files and directories in the Makefiles
> which install them.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Tim Deegan <tim@xen.org>
> ---
>  Makefile | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 3b9bf7a..abef019 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -232,21 +232,8 @@ help:
>  .PHONY: uninstall
>  uninstall: D=$(DESTDIR)
>  uninstall:
> -	[ -d $(D)$(XEN_CONFIG_DIR) ] && mv -f $(D)$(XEN_CONFIG_DIR) $(D)$(XEN_CONFIG_DIR).old-`date +%s` || true
>  	$(MAKE) -C xen uninstall
> -	rm -rf $(D)$(CONFIG_DIR)/init.d/xendomains $(D)$(CONFIG_DIR)/init.d/xend
> -	rm -rf $(D)$(CONFIG_DIR)/init.d/xencommons $(D)$(CONFIG_DIR)/init.d/xen-watchdog
> -	rm -f  $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
> -	rm -f  $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
> -	rm -f  $(D)$(SYSCONFIG_DIR)/xendomains
> -	rm -f  $(D)$(SBINDIR)/xendomains
> -	rm -f  $(D)$(SYSCONFIG_DIR)/xencommons
> -	rm -f  $(D)$(XEN_SYSTEMD_DIR)/*.service
> -	rm -f  $(D)$(XEN_SYSTEMD_DIR)/*.mount
> -	rm -f  $(D)$(XEN_SYSTEMD_MODULES_LOAD)/*.conf
> -	rm -rf  $(D)$(XEN_RUN_DIR)* $(D)/var/lib/xen*
> -	make -C tools uninstall
> -	rm -rf $(D)/boot/tboot*
> +	$(MAKE) -C tools uninstall
>  
>  .PHONY: xenversion
>  xenversion:
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel