From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 20/28] Put bash_completion.d below
 --sysconfdir=DIR
Date: Tue, 30 Sep 2014 16:58:36 +0100
Message-ID: <1412092716.31276.20.camel@citrix.com>
References: <1411658423-18877-1-git-send-email-olaf@aepfle.de>
	<1411658423-18877-21-git-send-email-olaf@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1411658423-18877-21-git-send-email-olaf@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-09-25 at 17:20 +0200, Olaf Hering wrote:
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Not sure the subject is 100% accurate, since it seems to just be moving
the location of the definition, not changing it in any way?

> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>  Config.mk          | 2 --
>  config/Paths.mk.in | 1 +
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Config.mk b/Config.mk
> index 73281d8..cf7af12 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -58,8 +58,6 @@ endif
>  include $(XEN_ROOT)/config/$(XEN_OS).mk
>  include $(XEN_ROOT)/config/$(XEN_TARGET_ARCH).mk
>  
> -BASH_COMPLETION_DIR ?= $(CONFIG_DIR)/bash_completion.d
> -
>  # arguments: variable, common path part, path to test, if yes, if no
>  define setvar_dir
>    ifndef $(1)
> diff --git a/config/Paths.mk.in b/config/Paths.mk.in
> index 8755785..e1fe4a3 100644
> --- a/config/Paths.mk.in
> +++ b/config/Paths.mk.in
> @@ -50,6 +50,7 @@ XEN_LIB_STORED           := @XEN_LIB_STORED@
>  
>  CONFIG_DIR               := @CONFIG_DIR@
>  INITD_DIR                := @INITD_DIR@
> +BASH_COMPLETION_DIR      := $(CONFIG_DIR)/bash_completion.d
>  XEN_LOCK_DIR             := @XEN_LOCK_DIR@
>  XEN_PAGING_DIR           := @XEN_PAGING_DIR@
>  
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel