From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 01/28] Neutralize make uninstall
Date: Wed, 1 Oct 2014 11:44:50 +0100
Message-ID: <1412160290.4861.15.camel@citrix.com>
References: <1411658423-18877-1-git-send-email-olaf@aepfle.de>
	<1411658423-18877-2-git-send-email-olaf@aepfle.de>
	<1411998589.3801.20.camel@citrix.com>
	<20140930120934.GC15029@aepfle.de>
	<20141001055259.GA29585@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20141001055259.GA29585@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-10-01 at 07:52 +0200, Olaf Hering wrote:
> On Tue, Sep 30, Olaf Hering wrote:
> 
> > On Mon, Sep 29, Ian Campbell wrote:
> > > Yet? Will this be replaced by additions to the appropriate submake files
> > > in the course of this series?
> > No. Unless I miss something, make uninstall can not work today. At least
> > for the toplevel Makefile. If you want I can add more uninstall parts to
> > the tools Makefiles in a separate series. Either for 4.5 or later.
> 
> Ian,
> 
> now that I look at staging-4.4 I see that the toplevel Makefile includes
> config/StdGNU.mk which sets path variables used by the uninstall target.
> So my series broke uninstall because the variables are not available
> anymore during 'make uninstall'.

Ah, I assumed it had already been broken by e.g. refactoring done for
systemd.

>  I think the right fix is to move the
> uninstall target to the invividual Makefiles in tools/hotplug/.
> XEN_RUN_DIR is created at runtime now, it should be left alone by
> uninstall. /var/lib/xen is created in tools/Makefile, so it should be
> removed there.

I agree. Having the uninstall rule near to the install will be helpful.

> I will adjust this patch and include it in v5 of this series.

Thanks.

Ian.