From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for-xen-4.5] xl: use nic global default
 values in network-attach
Date: Wed, 1 Oct 2014 11:46:45 +0100
Message-ID: <1412160405.4861.16.camel@citrix.com>
References: <1412160127-28088-1-git-send-email-roger.pau@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XZHQo-00069u-H6
	for xen-devel@lists.xenproject.org; Wed, 01 Oct 2014 10:46:50 +0000
In-Reply-To: <1412160127-28088-1-git-send-email-roger.pau@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org

T24gV2VkLCAyMDE0LTEwLTAxIGF0IDEyOjQyICswMjAwLCBSb2dlciBQYXUgTW9ubmUgd3JvdGU6
Cj4gSW50cm9kdWNlIGEgbmV3IHN0YXRpYyBmdW5jdGlvbiB0aGF0IHdpbGwgYmUgdXNlZCB0byBz
ZXQgdGhlIGluaXRpYWwgbmljCj4gY29uZmlnIGJhc2VkIG9uIHRoZSBnbG9iYWwgZGVmYXVsdHMu
IFRoaXMgZml4ZXMgYSBidWcgY2F1c2VkIGJ5Cj4gbmV0d29yay1hdHRhY2ggbm90IHVzaW5nIHRo
ZSBkZWZhdWx0IHZhbHVlcyBzZXQgaW4geGwuY29uZig1KS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBS
b2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KPiBDYzogSWFuIEphY2tzb24g
PGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+CgpBY2tlZC1ieTogSWFuIENhbXBiZWxsIDxpYW4u
Y2FtcGJlbGxAY2l0cml4LmNvbT4KCkknbSBzdXJlIHRoZXJlIGlzIG1vcmUgdW5pZmljYXRpb24g
d2hpY2ggY2FuIGJlIGRvbmUgZm9yIHRoZXNlIHRoaW5ncwpidXQgdGhpcyBpcyBhIHN0ZXAgaW4g
dGhlIHJpZ2h0IGRpcmVjdGlvbiwgdGhhbmtzIQoKPiBDYzogV2VpIExpdSA8d2VpLmxpdTJAY2l0
cml4LmNvbT4KPiAtLS0KPiAgdG9vbHMvbGlieGwveGxfY21kaW1wbC5jIHwgNDcgKysrKysrKysr
KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs
IDI3IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS90b29s
cy9saWJ4bC94bF9jbWRpbXBsLmMgYi90b29scy9saWJ4bC94bF9jbWRpbXBsLmMKPiBpbmRleCBk
MjA1Zjk2Li45NGZiNTM1IDEwMDY0NAo+IC0tLSBhL3Rvb2xzL2xpYnhsL3hsX2NtZGltcGwuYwo+
ICsrKyBiL3Rvb2xzL2xpYnhsL3hsX2NtZGltcGwuYwo+IEBAIC01MDYsNiArNTA2LDMwIEBAIHN0
YXRpYyB2b2lkIHBhcnNlX3ZpZl9yYXRlKFhMVV9Db25maWcgKipjb25maWcsIGNvbnN0IGNoYXIg
KnJhdGUsCj4gICAgICB9Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIHNldF9kZWZhdWx0X25pY192
YWx1ZXMobGlieGxfZGV2aWNlX25pYyAqbmljKQo+ICt7Cj4gKwo+ICsgICAgaWYgKGRlZmF1bHRf
dmlmc2NyaXB0KSB7Cj4gKyAgICAgICAgZnJlZShuaWMtPnNjcmlwdCk7Cj4gKyAgICAgICAgbmlj
LT5zY3JpcHQgPSBzdHJkdXAoZGVmYXVsdF92aWZzY3JpcHQpOwo+ICsgICAgfQo+ICsKPiArICAg
IGlmIChkZWZhdWx0X2JyaWRnZSkgewo+ICsgICAgICAgIGZyZWUobmljLT5icmlkZ2UpOwo+ICsg
ICAgICAgIG5pYy0+YnJpZGdlID0gc3RyZHVwKGRlZmF1bHRfYnJpZGdlKTsKPiArICAgIH0KPiAr
Cj4gKyAgICBpZiAoZGVmYXVsdF9nYXRld2F5ZGV2KSB7Cj4gKyAgICAgICAgZnJlZShuaWMtPmdh
dGV3YXlkZXYpOwo+ICsgICAgICAgIG5pYy0+Z2F0ZXdheWRldiA9IHN0cmR1cChkZWZhdWx0X2dh
dGV3YXlkZXYpOwo+ICsgICAgfQo+ICsKPiArICAgIGlmIChkZWZhdWx0X3ZpZmJhY2tlbmQpIHsK
PiArICAgICAgICBmcmVlKG5pYy0+YmFja2VuZF9kb21uYW1lKTsKPiArICAgICAgICBuaWMtPmJh
Y2tlbmRfZG9tbmFtZSA9IHN0cmR1cChkZWZhdWx0X3ZpZmJhY2tlbmQpOwo+ICsgICAgfQo+ICt9
Cj4gKwo+ICBzdGF0aWMgdm9pZCBzcGxpdF9zdHJpbmdfaW50b19zdHJpbmdfbGlzdChjb25zdCBj
aGFyICpzdHIsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNv
bnN0IGNoYXIgKmRlbGltLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBsaWJ4bF9zdHJpbmdfbGlzdCAqcHNsKQo+IEBAIC0xMzU0LDI2ICsxMzc4LDcgQEAgc3Rh
dGljIHZvaWQgcGFyc2VfY29uZmlnX2RhdGEoY29uc3QgY2hhciAqY29uZmlnX3NvdXJjZSwKPiAg
ICAgICAgICAgICAgbmljID0gZF9jb25maWctPm5pY3MgKyBkX2NvbmZpZy0+bnVtX25pY3M7Cj4g
ICAgICAgICAgICAgIGxpYnhsX2RldmljZV9uaWNfaW5pdChuaWMpOwo+ICAgICAgICAgICAgICBu
aWMtPmRldmlkID0gZF9jb25maWctPm51bV9uaWNzOwo+IC0KPiAtICAgICAgICAgICAgaWYgKGRl
ZmF1bHRfdmlmc2NyaXB0KSB7Cj4gLSAgICAgICAgICAgICAgICBmcmVlKG5pYy0+c2NyaXB0KTsK
PiAtICAgICAgICAgICAgICAgIG5pYy0+c2NyaXB0ID0gc3RyZHVwKGRlZmF1bHRfdmlmc2NyaXB0
KTsKPiAtICAgICAgICAgICAgfQo+IC0KPiAtICAgICAgICAgICAgaWYgKGRlZmF1bHRfYnJpZGdl
KSB7Cj4gLSAgICAgICAgICAgICAgICBmcmVlKG5pYy0+YnJpZGdlKTsKPiAtICAgICAgICAgICAg
ICAgIG5pYy0+YnJpZGdlID0gc3RyZHVwKGRlZmF1bHRfYnJpZGdlKTsKPiAtICAgICAgICAgICAg
fQo+IC0KPiAtICAgICAgICAgICAgaWYgKGRlZmF1bHRfZ2F0ZXdheWRldikgewo+IC0gICAgICAg
ICAgICAgICAgZnJlZShuaWMtPmdhdGV3YXlkZXYpOwo+IC0gICAgICAgICAgICAgICAgbmljLT5n
YXRld2F5ZGV2ID0gc3RyZHVwKGRlZmF1bHRfZ2F0ZXdheWRldik7Cj4gLSAgICAgICAgICAgIH0K
PiAtCj4gLSAgICAgICAgICAgIGlmIChkZWZhdWx0X3ZpZmJhY2tlbmQpIHsKPiAtICAgICAgICAg
ICAgICAgIGZyZWUobmljLT5iYWNrZW5kX2RvbW5hbWUpOwo+IC0gICAgICAgICAgICAgICAgbmlj
LT5iYWNrZW5kX2RvbW5hbWUgPSBzdHJkdXAoZGVmYXVsdF92aWZiYWNrZW5kKTsKPiAtICAgICAg
ICAgICAgfQo+ICsgICAgICAgICAgICBzZXRfZGVmYXVsdF9uaWNfdmFsdWVzKG5pYyk7Cj4gIAo+
ICAgICAgICAgICAgICBwID0gc3RydG9rKGJ1ZjIsICIsIik7Cj4gICAgICAgICAgICAgIGlmICgh
cCkKPiBAQCAtNjAwNSw2ICs2MDEwLDggQEAgaW50IG1haW5fbmV0d29ya2F0dGFjaChpbnQgYXJn
YywgY2hhciAqKmFyZ3YpCj4gICAgICB9Cj4gIAo+ICAgICAgbGlieGxfZGV2aWNlX25pY19pbml0
KCZuaWMpOwo+ICsgICAgc2V0X2RlZmF1bHRfbmljX3ZhbHVlcygmbmljKTsKPiArCj4gICAgICBm
b3IgKGFyZ3YgKz0gb3B0aW5kKzEsIGFyZ2MgLT0gb3B0aW5kKzE7IGFyZ2MgPiAwOyArK2FyZ3Ys
IC0tYXJnYykgewo+ICAgICAgICAgIGlmIChNQVRDSF9PUFRJT04oInR5cGUiLCAqYXJndiwgb3Bh
cmcpKSB7Cj4gICAgICAgICAgICAgIGlmICghc3RyY21wKCJ2aWYiLCBvcGFyZykpIHsKCgoKX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1h
aWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94
ZW4tZGV2ZWwK