From: Ian Campbell <Ian.Campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com,
Prasun.Kapoor@caviumnetworks.com,
vijaya.kumar@caviumnetworks.com, tim@xen.org,
xen-devel@lists.xen.org, stefano.stabellini@citrix.com,
manish.jaggi@caviumnetworks.com
Subject: Re: [PATCH v2] xen/arm: check on domain type against hardware support
Date: Wed, 1 Oct 2014 11:55:03 +0100 [thread overview]
Message-ID: <1412160903.4861.18.camel@citrix.com> (raw)
In-Reply-To: <54295060.9010909@linaro.org>
On Mon, 2014-09-29 at 13:28 +0100, Julien Grall wrote:
> Hi Ian,
>
> On 09/29/2014 01:23 PM, Ian Campbell wrote:
> > On Fri, 2014-09-26 at 11:28 +0530, vijay.kilari@gmail.com wrote:
> >> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> >>
> >> Some arm64 platforms implement only aarch64 mode. So allow
> >> domains that are only 64-bit
> >>
> >> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> >
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > I think this is a bug fix so we should take it for 4.5.
>
> I made a quick comment in response to your answer on V1.
Vijay, based on Julien's comments on v1 I'm inclined to
s/cpu_has_a32/cpu_has_arm/, so we refer to arm+thumb not a32+thumb which
combines to different naming schemes. An alternative would be
s/cpu_has_thumb/cpu_has_t32/ but I don't like that much.
Does that work for you? I can make the trivial change so no need to
resend (unless you want to).
Ian.
next prev parent reply other threads:[~2014-10-01 10:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 5:58 [PATCH v2] xen/arm: check on domain type against hardware support vijay.kilari
2014-09-29 12:23 ` Ian Campbell
2014-09-29 12:28 ` Julien Grall
2014-09-29 15:22 ` Konrad Rzeszutek Wilk
2014-10-01 10:55 ` Ian Campbell [this message]
2014-10-06 6:43 ` Vijay Kilari
2014-10-06 13:49 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412160903.4861.18.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=julien.grall@linaro.org \
--cc=manish.jaggi@caviumnetworks.com \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=vijay.kilari@gmail.com \
--cc=vijaya.kumar@caviumnetworks.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).