From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] xen/arm: check on domain type against hardware support Date: Wed, 1 Oct 2014 11:55:03 +0100 Message-ID: <1412160903.4861.18.camel@citrix.com> References: <1411711127-24136-1-git-send-email-vijay.kilari@gmail.com> <1411993430.3801.5.camel@citrix.com> <54295060.9010909@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54295060.9010909@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On Mon, 2014-09-29 at 13:28 +0100, Julien Grall wrote: > Hi Ian, > > On 09/29/2014 01:23 PM, Ian Campbell wrote: > > On Fri, 2014-09-26 at 11:28 +0530, vijay.kilari@gmail.com wrote: > >> From: Vijaya Kumar K > >> > >> Some arm64 platforms implement only aarch64 mode. So allow > >> domains that are only 64-bit > >> > >> Signed-off-by: Vijaya Kumar K > > > > Acked-by: Ian Campbell > > > > I think this is a bug fix so we should take it for 4.5. > > I made a quick comment in response to your answer on V1. Vijay, based on Julien's comments on v1 I'm inclined to s/cpu_has_a32/cpu_has_arm/, so we refer to arm+thumb not a32+thumb which combines to different naming schemes. An alternative would be s/cpu_has_thumb/cpu_has_t32/ but I don't like that much. Does that work for you? I can make the trivial change so no need to resend (unless you want to). Ian.