From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for 4.5] xen/arm: p2m: Correctly initialize
 cur_offset
Date: Wed, 1 Oct 2014 16:03:29 +0100
Message-ID: <1412175809.4861.41.camel@citrix.com>
References: <1412088716-32557-1-git-send-email-julien.grall@linaro.org>
	<1412159612.4861.10.camel@citrix.com> <542C1717.3000700@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XZLRY-0008Ae-Re
	for xen-devel@lists.xenproject.org; Wed, 01 Oct 2014 15:03:52 +0000
In-Reply-To: <542C1717.3000700@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-10-01 at 16:00 +0100, Julien Grall wrote:
> On 10/01/2014 11:33 AM, Ian Campbell wrote:
> > On Tue, 2014-09-30 at 15:51 +0100, Julien Grall wrote:
> >> {~0,} only initializes the first cell of the array to ~0. The other cells
> >> are initialized to 0.
> >>
> >> Change the initialization to a loop and, at the same time, do the same
> >> for the mappings.
> > 
> > I'm not sure a loop is the best option here vs either { ~0, ~0, ~0, ~0 }
> > or a memset, but OK.
> 
> Thinking a bit more, we effectively need to initialize only the first 2
> cells. It's because the P2M can start either at level 0 or level 1.
> 
> Anyway I will use { ~0, ~0, ~0, ~0 }.
> 
> > I don't think mappings is wrong as it is though, any reason to change?
> 
> { NULL, } initialize the first cell to NULL and the other to 0.
> 
> As NULL is equal to (void *)0 it's fine, but I would prefer if we can
> get a rid of this construction.
> 
> I would prefer if we do { NULL, NULL, NULL, NULL }.

OK.

> 
> >> This is fixing boot after 82985d7 "xen: arm: handle variable p2m levels
> >> in apply_p2m_changes" on platform where the root-level doesn't have
> >> concatenate table (such as the Foundation Model).
> > 
> > You forgot your S-o-b.
> 
> Oh right. I will resend a patch
> 
> 
>