From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [RFC PATCH 2/2] arm64: Create xen.efi binary for arm64 Date: Thu, 2 Oct 2014 15:08:14 +0100 Message-ID: <1412258894.17146.12.camel@citrix.com> References: <1412212299-13831-1-git-send-email-roy.franz@linaro.org> <1412212299-13831-3-git-send-email-roy.franz@linaro.org> <1412255000.17146.11.camel@citrix.com> <542D6ABA020000780003BFC5@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <542D6ABA020000780003BFC5@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: keir@xen.org, tim@xen.org, xen-devel@lists.xen.org, Roy Franz , stefano.stabellini@citrix.com, fu.wei@linaro.org List-Id: xen-devel@lists.xenproject.org On Thu, 2014-10-02 at 14:09 +0100, Jan Beulich wrote: > >>> On 02.10.14 at 15:03, wrote: > > On Wed, 2014-10-01 at 18:11 -0700, Roy Franz wrote: > >> The 'xen' binary for arm64 is both an Image file and a PE/COFF executable, > >> copy it to xen.efi so that the 'make install' processing is shared with > >> x86. Prior to this 'make install' was broken on arm64. > >> > >> Signed-off-by: Roy Franz > > > > If the affect of this is only to install Xen (and some symlinks) > > into /usr/lib64/efi and optionally into the ESP then: > > Acked-by: Ian Campbell > > > > What I don't want is for an extra xen.efi to show up in the > > regular /boot directory. I think this patch doesn't do that though. > > > > Jan, slight aside: what do you think about setting EFI_VENDOR to e.g. > > XenProject by default (i.e. installing into the ESP by default)? > > The respective directory on the EFI partition ought to exist (and > I don't think we should be creating it). This part of the installation > being only an aid for developers anyway, I'd prefer keeping > EFI_VENDOR undefined (and hence skipping that installation step) > by default. Makes sense to me, thanks. Ian.