From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 01/28] tools: fix make uninstall Date: Thu, 2 Oct 2014 15:11:39 +0100 Message-ID: <1412259099.17146.16.camel@citrix.com> References: <1412181690-19609-1-git-send-email-olaf@aepfle.de> <1412181690-19609-2-git-send-email-olaf@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1412181690-19609-2-git-send-email-olaf@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Wei Liu , Ian Jackson , Stefano Stabellini , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2014-10-01 at 18:41 +0200, Olaf Hering wrote: > The uninstall target does not know about the paths it removes because > the toplevel Makefile does not include the required files. > > Move the commands to tools/Makefile because all files come from subdirs > in tools/ anyway. Drop the removal of $(XEN_RUN_DIR) because it gets > created at runtime. Drop the removal of systemd related files because > the wildcard matches everything. > > The proper fix is to remove the files and directories in the Makefiles > which install them. But this version is the least intrusive change at > this point. > > Signed-off-by: Olaf Hering > Cc: Ian Jackson > Cc: Stefano Stabellini Acked-by: Ian Campbell