From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH v2] sg-report-flight: Add a succcess/failure column header. Date: Fri, 3 Oct 2014 09:38:58 +0100 Message-ID: <1412325538.423.5.camel@citrix.com> References: <1412250966-14374-1-git-send-email-ian.campbell@citrix.com> <1412269596-27733-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XZyOG-0000Nl-Ni for xen-devel@lists.xenproject.org; Fri, 03 Oct 2014 08:39:04 +0000 In-Reply-To: <1412269596-27733-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, 2014-10-02 at 18:06 +0100, Ian Jackson wrote: > From: Ian Campbell > > There are so many rows and columns that scrolling around trying to find the > column associated with a failure is getting pretty tricky. Finding all failing > columns is even harder. > > Add a clue near the top: replicate the worst or most interesting step > result box contents and colour. > > Signed-off-by: Ian Campbell > Signed-off-by: Ian Jackson > > --- > v2: Do it entirely differently. The result is indeed better, but it's different enough that I think you can drop the From:. Personally I'd have made $cell_html include the "" in the result, since both of the callers just paste it into that context anyway, but up to you. Ian.