From: Ian Campbell <Ian.Campbell@citrix.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Thomas Leonard <talex5@gmail.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
David Scott <Dave.Scott@eu.citrix.com>,
Anil Madhavapeddy <anil@recoil.org>
Subject: Re: [PATCH] mini-os: enable compiler check for printk format types
Date: Mon, 6 Oct 2014 14:28:50 +0100 [thread overview]
Message-ID: <1412602130.14255.8.camel@citrix.com> (raw)
In-Reply-To: <20141005193018.GP5718@type>
On Sun, 2014-10-05 at 21:30 +0200, Samuel Thibault wrote:
> > Samuel, are you ok with the patch after those clarifications?
>
> Yes.
I interpreted this as an Acked-by, I hope that's ok, and was about to
commit when:
disk_read.c: In function 'vtpm_load_disk':
disk_read.c:539:59: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format]
disk_read.c:539:59: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format]
disk_read.c:540:2: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format]
disk_read.c:540:2: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format]
disk_read.c:542:30: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format]
disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format]
disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format]
disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format]
disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format]
disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format]
disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format]
disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Werror=format]
disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format]
disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format]
disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format]
That's on an x86_32 stubdom build.
Looks like this is printing the output of sizeof. The correct modifier
for printing a size_t is %zu not hardcoded as a long. I haven't checked
if mini-os printf supports z.
> Reviewing it just kept being behind loads of stuff in my TODO list :/
I know the feeling :-/
next prev parent reply other threads:[~2014-10-06 13:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 9:44 [PATCH] mini-os: enable compiler check for printk format types Thomas Leonard
2014-08-06 16:29 ` Andrew Cooper
2014-08-07 6:33 ` Jan Beulich
2014-08-07 14:55 ` Samuel Thibault
2014-08-08 8:50 ` Thomas Leonard
2014-08-08 14:28 ` Thomas Leonard
2014-08-08 14:32 ` Samuel Thibault
2014-10-03 8:44 ` Thomas Leonard
2014-10-03 8:55 ` Ian Campbell
2014-10-05 19:30 ` Samuel Thibault
2014-10-06 13:28 ` Ian Campbell [this message]
2014-10-07 16:04 ` Samuel Thibault
2014-10-08 11:12 ` Thomas Leonard
2014-10-08 11:16 ` Andrew Cooper
2014-10-08 11:25 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412602130.14255.8.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Dave.Scott@eu.citrix.com \
--cc=anil@recoil.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=talex5@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).