From: Ian Campbell <Ian.Campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Olaf Hering <olaf@aepfle.de>, Wei Liu <wei.liu2@citrix.com>,
David Scott <dave.scott@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Keir Fraser <keir@xen.org>
Subject: Re: [PATCH v2] Separate runtime debug output from debug symbols
Date: Wed, 8 Oct 2014 13:45:00 +0100 [thread overview]
Message-ID: <1412772300.9247.30.camel@citrix.com> (raw)
In-Reply-To: <54327711020000780003C5CF@mail.emea.novell.com>
On Mon, 2014-10-06 at 10:03 +0100, Jan Beulich wrote:
> >>> On 06.10.14 at 10:55, <olaf@aepfle.de> wrote:
> > Two make variables exist (debug=y and debug_symbols=y) to control either
> > the creation of additional runtime debug or the creation of debug
> > symbols for tools like gdb. Some places in the code still passed -g
> > unconditionally to the compiler. Wrap them into a "debug_symbols"
> > conditional. The xen build passed -g unconditional, reuse the existing
> > debug_symbols=y check in Config.mk. There are still parts of the code
> > that hardcode -g, namely the external qemu-traditional and stubdom
> > packages. They are not changed by this patch.
> >
> > No change in behaviour is expected by that patch for tools and xen.
> > For stubdom CFLAGS change from -O1 to O2 with debug=n.
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >[...]
> > xen/Rules.mk | 2 +-
>
> For just this small part of the patch:
> Acked-by: Jan Beulich <jbeulich@suse.com>
Unfortunately this seems to cause:
/usr/bin/wget -c -O zlib-1.2.3.tar.gz /zlib-1.2.3.tar.gz
/zlib-1.2.3.tar.gz: Scheme missing.
I think the reordering in stubdom/Makefile has caused XEN_EXTFILES_URL
to not be defined at the correct point in time.
Ian.
next prev parent reply other threads:[~2014-10-08 12:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 16:41 [PATCH 00/28 v5 for-xen-4.5] tool changes to honor configure --prefix=DIR Olaf Hering
2014-10-01 16:41 ` [PATCH 01/28] tools: fix make uninstall Olaf Hering
2014-10-02 14:11 ` Ian Campbell
2014-10-01 16:41 ` [PATCH 02/28] tools/hotplug: fix race during xen.conf creation Olaf Hering
2014-10-06 13:48 ` Konrad Rzeszutek Wilk
2014-10-01 16:41 ` [PATCH 03/28] tools/python: use also LDFLAGS for build Olaf Hering
2014-10-01 16:41 ` [PATCH 04/28] Add configure --with-initddir=DIR Olaf Hering
2014-10-01 16:41 ` [PATCH 05/28] tools/hotplug: use XEN_SCRIPT_DIR instead of hardcoded path Olaf Hering
2014-10-01 16:41 ` [PATCH 06/28] tools/configure.ac: sort AC_CONFIG_FILES Olaf Hering
2014-10-01 16:41 ` [PATCH 07/28] tools/hotplug: use INITD_DIR instead of CONFIG_DIR/init.d|rc.d Olaf Hering
2014-10-01 16:41 ` [PATCH 08/28] tools/hotplug: substitute XEN_SCRIPT_DIR on FreeBSD Olaf Hering
2014-10-01 16:41 ` [PATCH 09/28] remove duplicate variables from config Olaf Hering
2014-10-01 16:41 ` [PATCH 10/28] Substitue configure variables in Paths.mk.in Olaf Hering
2014-10-01 16:41 ` [PATCH 11/28] tools: substitute bindir instead of BINDIR Olaf Hering
2014-10-01 16:41 ` [PATCH 12/28] Use configure --mandir=DIR to set MANDIR Olaf Hering
2014-10-01 16:41 ` [PATCH 13/28] Use configure --docdir=DIR to set DOCDIR Olaf Hering
2014-10-01 16:41 ` [PATCH 14/28] Use configure --includedir=DIR to set INCLUDEDIR Olaf Hering
2014-10-01 16:41 ` [PATCH 15/28] Use configure --libexecdir=BASEDIR to set LIBEXEC Olaf Hering
2014-10-06 15:40 ` Ian Campbell
2014-10-06 15:53 ` [PATCH] QEMU_TAG update FOR FOLDING INTO LIBEXEC PATCH Ian Jackson
2014-10-07 6:52 ` [PATCH 15/28] Use configure --libexecdir=BASEDIR to set LIBEXEC Olaf Hering
2014-10-01 16:41 ` [PATCH 16/28] Use configure --prefix=DIR to set PREFIX Olaf Hering
2014-10-01 16:41 ` [PATCH 17/28] Use configure --localstatedir=BASEDIR to set path to /var Olaf Hering
2014-10-01 16:41 ` [PATCH 18/28] Add configure --enable-rpath Olaf Hering
2014-10-01 16:41 ` [PATCH 19/28] Add configure --with-linux-backend-modules="mod1 mod2" Olaf Hering
2014-10-01 16:41 ` [PATCH 20/28] Move variable to set bash_completion.d to Paths.mk Olaf Hering
2014-10-01 16:41 ` [PATCH 21/28] Add configure --with-sysconfig-leaf-dir=SUBDIR to set CONFIG_LEAF_DIR Olaf Hering
2014-10-01 16:41 ` [PATCH 22/28] Make XENFIRMWAREDIR a subdir of libexecdir Olaf Hering
2014-10-01 16:41 ` [PATCH 23/28] tools: remove private copies of includedir and libdir from libxenstat Olaf Hering
2014-10-01 16:41 ` [PATCH 24/28] Use Paths.mk for docs, stubdom and tools build Olaf Hering
2014-10-01 16:41 ` [PATCH 25/28] tools: use XEN_LIB_STORED instead of /var/lib/xenstored Olaf Hering
2014-10-01 16:41 ` [PATCH 26/28] tools/hotplug: Use XEN_RUN_DIR instead of /var/run/xen Olaf Hering
2014-10-01 16:41 ` [PATCH 27/28] move vtpmmgr helpers from tools to stubdom Olaf Hering
2014-10-01 21:51 ` Daniel De Graaf
2014-10-01 16:41 ` [PATCH 28/28] Separate runtime debug output from debug symbols Olaf Hering
2014-10-02 7:26 ` Jan Beulich
2014-10-02 8:00 ` Olaf Hering
2014-10-02 8:06 ` Jan Beulich
2014-10-02 9:52 ` Tim Deegan
2014-10-02 10:27 ` Jan Beulich
2014-10-02 16:52 ` Andrew Cooper
2014-10-06 7:31 ` Jan Beulich
2014-10-06 7:40 ` Olaf Hering
2014-10-02 10:45 ` Olaf Hering
2014-10-02 14:15 ` Ian Campbell
2014-10-06 8:55 ` [PATCH v2] " Olaf Hering
2014-10-06 9:03 ` Jan Beulich
2014-10-08 12:45 ` Ian Campbell [this message]
2014-10-08 12:55 ` Olaf Hering
2014-10-08 13:18 ` Olaf Hering
2014-10-06 14:05 ` [PATCH 00/28 v5 for-xen-4.5] tool changes to honor configure --prefix=DIR Konrad Rzeszutek Wilk
2014-10-06 16:32 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412772300.9247.30.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=dave.scott@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=olaf@aepfle.de \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).