From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2] Separate runtime debug output from debug
	symbols
Date: Wed, 8 Oct 2014 13:45:00 +0100
Message-ID: <1412772300.9247.30.camel@citrix.com>
References: <1412181690-19609-29-git-send-email-olaf@aepfle.de>
	<1412585751-1525-1-git-send-email-olaf@aepfle.de>
	<54327711020000780003C5CF@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1Xbqc5-0006Pb-Tw
	for xen-devel@lists.xenproject.org; Wed, 08 Oct 2014 12:45:06 +0000
In-Reply-To: <54327711020000780003C5CF@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Olaf Hering <olaf@aepfle.de>, Wei Liu <wei.liu2@citrix.com>, David Scott <dave.scott@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org>, Samuel Thibault <samuel.thibault@ens-lyon.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-10-06 at 10:03 +0100, Jan Beulich wrote:
> >>> On 06.10.14 at 10:55, <olaf@aepfle.de> wrote:
> > Two make variables exist (debug=y and debug_symbols=y) to control either
> > the creation of additional runtime debug or the creation of debug
> > symbols for tools like gdb.  Some places in the code still passed -g
> > unconditionally to the compiler. Wrap them into a "debug_symbols"
> > conditional. The xen build passed -g unconditional, reuse the existing
> > debug_symbols=y check in Config.mk. There are still parts of the code
> > that hardcode -g, namely the external qemu-traditional and stubdom
> > packages. They are not changed by this patch.
> > 
> > No change in behaviour is expected by that patch for tools and xen.
> > For stubdom CFLAGS change from -O1 to O2 with debug=n.
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >[...]
> >  xen/Rules.mk            | 2 +-
> 
> For just this small part of the patch:
> Acked-by: Jan Beulich <jbeulich@suse.com>

Unfortunately this seems to cause:

        /usr/bin/wget -c -O zlib-1.2.3.tar.gz /zlib-1.2.3.tar.gz
        /zlib-1.2.3.tar.gz: Scheme missing.

I think the reordering in stubdom/Makefile has caused XEN_EXTFILES_URL
to not be defined at the correct point in time.

Ian.