From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH RFC OSSTEST 10/19] make-flight: Run a basic test on each arm platform Date: Fri, 10 Oct 2014 15:27:31 +0100 Message-ID: <1412951251.27111.31.camel@citrix.com> References: <1412942404.27111.12.camel@citrix.com> <1412942554-752-10-git-send-email-ian.campbell@citrix.com> <21559.60178.137137.562484@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21559.60178.137137.562484@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2014-10-10 at 15:20 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH RFC OSSTEST 10/19] make-flight: Run a basic test on each arm platform"): > > Unlike x86 there is enough variation in the ARM platforms that it is > > worth having a basic test on each as part of a standard run. This > > relies on each host having an appropriate equiv-$platform host flag. > > I think using equiv-* for this is not correct. > > Hosts named equiv-* are supposed to be completely identical, but we > might end up with hosts which are similar enough that they qualify for > this cross-architecture testing, and but not completely identical. > > Furthermore, using equiv-* makes it difficult to automatically search > for a list of the different board classes we would want to use. > > I would invent a new prefix. Perhaps flags like > platform-midway > etc. Would I have to add some code somewhere to process this? (I'm often surprised to find that these just work via some generic magic, e.g. the buildjob stuff etc, but I don't think so in this case?) Perhaps in ts-hosts-allocate-Executive alongside the equiv handling? > Then you could search the database > > SELECT UNIQUE platform > WHERE EXISTS host > SUCHTHAT (host,"arch-$arch") in hostflags > AND (host,"blessed-$whatever") in hostflags > etc. > > rather than hardcoding the list in make-flight. I think this wouldn't work for standalone mode, would it? > > Currently the existing arm midway boxes are "equiv-marilith", this > > turns out to be a bad choice at least for this purpose, since > > marilith is the host name, not the platform, we should either switch > > to or add equiv-midway. ISTR discussing this at the time and picking > > equiv-marilith pretty much arbitrarily, AFAIK nothing is using it > > explicitly today so I think removing and adding equiv-midway is the > > right choice. > > See above. `equiv-marilith' would be correct if we had another > identical Calxeda box. Given "marilith" is the host name and not any sort of name which would identify "similar" machines -- really?