From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH RFC OSSTEST 13/19] Osstest/Debian: Install dtbs into target filesystem in /boot/dtbs Date: Fri, 10 Oct 2014 15:49:34 +0100 Message-ID: <1412952574.27111.41.camel@citrix.com> References: <1412942404.27111.12.camel@citrix.com> <1412942554-752-13-git-send-email-ian.campbell@citrix.com> <21559.61712.597015.229563@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21559.61712.597015.229563@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2014-10-10 at 15:45 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH RFC OSSTEST 13/19] Osstest/Debian: Install dtbs into target filesystem in /boot/dtbs"): > > This is done unconditionally for every platform which has a > > need-kernel-deb-* flag, which is currently all ARM platforms. Since > > mg-debian-installer-update produces the necessary inputs for the only such > > kernel (armmp) this seems tolerable for now. > > Surely it would be better to check whether the source file exists and > use it iff it does ? I think I was just being lazy trying to reuse the existing hook script etc. I could throw the script text into a variable and include it that way though.