* [PATCH] blktap: CONFIG_GCRYPT detection
@ 2014-10-28 12:35 Martin Pohlack
2014-11-04 10:48 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Martin Pohlack @ 2014-10-28 12:35 UTC (permalink / raw)
To: xen-devel; +Cc: Martin Pohlack
Wrap make variable in () to allow correct evaluation.
This fixes broken CONFIG_GCRYPT detection which was introduced by
commit 85896a7c4dc7b6b1dba2db79dfb0ca61738a92a4 in 2012.
Signed-off-by: Martin Pohlack <mpohlack@amazon.de>
Reviewed-by: Uwe Dannowski <uwed@amazon.de>
Reviewed-by: Anthony Liguori <aliguori@amazon.com>
Reviewed-by: Matt Wilson <msw@amazon.com>
---
tools/blktap/drivers/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/blktap/drivers/Makefile b/tools/blktap/drivers/Makefile
index 7461a95..cea8b3b 100644
--- a/tools/blktap/drivers/Makefile
+++ b/tools/blktap/drivers/Makefile
@@ -11,7 +11,7 @@ CFLAGS += $(CFLAGS_libxenctrl)
CFLAGS += $(CFLAGS_libxenstore)
CFLAGS += -D_GNU_SOURCE
-ifeq ($CONFIG_GCRYPT,y)
+ifeq ($(CONFIG_GCRYPT),y)
CFLAGS += -DUSE_GCRYPT
CRYPT_LIB := -lgcrypt
else
--
2.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] blktap: CONFIG_GCRYPT detection
2014-10-28 12:35 [PATCH] blktap: CONFIG_GCRYPT detection Martin Pohlack
@ 2014-11-04 10:48 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2014-11-04 10:48 UTC (permalink / raw)
To: Martin Pohlack, Konrad Rzeszutek Wilk; +Cc: xen-devel
On Tue, 2014-10-28 at 13:35 +0100, Martin Pohlack wrote:
> Wrap make variable in () to allow correct evaluation.
>
> This fixes broken CONFIG_GCRYPT detection which was introduced by
> commit 85896a7c4dc7b6b1dba2db79dfb0ca61738a92a4 in 2012.
>
> Signed-off-by: Martin Pohlack <mpohlack@amazon.de>
> Reviewed-by: Uwe Dannowski <uwed@amazon.de>
> Reviewed-by: Anthony Liguori <aliguori@amazon.com>
> Reviewed-by: Matt Wilson <msw@amazon.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
You didn't mention if you considered this 4.5 material, but I think it
is a pretty obvious/safe bugfix so I've applied it.
> ---
> tools/blktap/drivers/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/blktap/drivers/Makefile b/tools/blktap/drivers/Makefile
> index 7461a95..cea8b3b 100644
> --- a/tools/blktap/drivers/Makefile
> +++ b/tools/blktap/drivers/Makefile
> @@ -11,7 +11,7 @@ CFLAGS += $(CFLAGS_libxenctrl)
> CFLAGS += $(CFLAGS_libxenstore)
> CFLAGS += -D_GNU_SOURCE
>
> -ifeq ($CONFIG_GCRYPT,y)
> +ifeq ($(CONFIG_GCRYPT),y)
> CFLAGS += -DUSE_GCRYPT
> CRYPT_LIB := -lgcrypt
> else
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-04 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-28 12:35 [PATCH] blktap: CONFIG_GCRYPT detection Martin Pohlack
2014-11-04 10:48 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).