From: Ian Campbell <Ian.Campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Daniel Kiper <daniel.kiper@oracle.com>, tim <tim@xen.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
xen-devel <xen-devel@lists.xen.org>,
Roy Franz <roy.franz@linaro.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Fu Wei <fu.wei@linaro.org>
Subject: Re: [PATCH V2 for-4.5] EFI: Always use EFI command line
Date: Thu, 30 Oct 2014 10:24:06 +0000 [thread overview]
Message-ID: <1414664646.2064.25.camel@citrix.com> (raw)
In-Reply-To: <545217BB0200007800043656@mail.emea.novell.com>
On Thu, 2014-10-30 at 09:49 +0000, Jan Beulich wrote:
> >>> On 30.10.14 at 03:21, <roy.franz@linaro.org> wrote:
> > So the open question is, when booted from GRUB (or other bootloader),
> > should Xen get it's commandline via the EFI
> > commandline, or via the MB2 protocol? (and for arm64, this means the
> > FDT based multiboot.) I felt that the shared code
> > in GRUB was a reasonable reason to follow what Linux did in the EFI case.
Isn't the "unshared" code here an if statement (or maybe two)? I don't
see why this one difference would require a troublesome amount of
separation the implementations.
> Consistency would call for MB2/FDT, but in the end this can very well
> be arch-specific imo (but in that case the patch also needs to reflect
> this).
I don't have a strong opinion either way, but if it is to change for
arm64 I'd like to see a proposed update to
http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot
as a starting point for deciding.
It needs to be careful not to break the "multiboot as a series of u-boot
fdt commands" case too.
Ian.
next prev parent reply other threads:[~2014-10-30 10:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 23:41 [PATCH V2 for-4.5] EFI: Always use EFI command line Roy Franz
2014-10-25 9:06 ` Ian Campbell
2014-10-25 9:27 ` Fu Wei
2014-10-25 10:22 ` Fu Wei
2014-10-25 19:18 ` Roy Franz
2014-10-27 10:55 ` Jan Beulich
2014-10-27 22:29 ` Roy Franz
2014-10-28 1:15 ` Konrad Rzeszutek Wilk
2014-10-28 7:48 ` Jan Beulich
2014-10-29 3:23 ` Roy Franz
2014-10-29 8:40 ` Jan Beulich
2014-10-29 12:44 ` Daniel Kiper
2014-10-29 15:26 ` Ian Campbell
2014-10-29 16:55 ` Daniel Kiper
2014-10-30 2:21 ` Roy Franz
2014-10-30 9:49 ` Jan Beulich
2014-10-30 10:24 ` Ian Campbell [this message]
2014-10-30 17:57 ` Daniel Kiper
2014-10-30 19:29 ` Roy Franz
2014-10-30 22:18 ` Daniel Kiper
2014-10-30 23:54 ` Roy Franz
2014-11-04 21:49 ` Daniel Kiper
2014-11-04 22:48 ` Roy Franz
2014-11-05 14:30 ` Daniel Kiper
2014-11-06 5:35 ` Roy Franz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414664646.2064.25.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=daniel.kiper@oracle.com \
--cc=fu.wei@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).