From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH V2 for-4.5] EFI: Always use EFI command line
Date: Thu, 30 Oct 2014 10:24:06 +0000
Message-ID: <1414664646.2064.25.camel@citrix.com>
References: <1414194069-24690-1-git-send-email-roy.franz@linaro.org>
	<1414227980.3584.15.camel@citrix.com>
	<CAFECyb_-uiaG0+3HxXs6kDksf6PdyUP5VEEr7AM6jH2xvLShnw@mail.gmail.com>
	<544E32CE02000078000425ED@mail.emea.novell.com>
	<CAFECyb896nCK-ANAC8G12yk+br_Sz=bHhbLEnr-MMikit7jrHw@mail.gmail.com>
	<544F58770200007800042ADA@mail.emea.novell.com>
	<CAFECyb-WsRpH4ee1XE5dZdxwygH-7hy-Nw8-ZEQtJF8Wnng8wA@mail.gmail.com>
	<20141029124411.GA3467@olila.local.net-space.pl>
	<1414596400.29580.12.camel@citrix.com>
	<20141029165526.GB3467@olila.local.net-space.pl>
	<CAFECyb_Q34S=L2Sy+PvLMBkZnct7z5y-u_c0Naush3oa2qnpng@mail.gmail.com>
	<545217BB0200007800043656@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <545217BB0200007800043656@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Daniel Kiper <daniel.kiper@oracle.com>, tim <tim@xen.org>, Leif Lindholm <leif.lindholm@linaro.org>, xen-devel <xen-devel@lists.xen.org>, Roy Franz <roy.franz@linaro.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Fu Wei <fu.wei@linaro.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-10-30 at 09:49 +0000, Jan Beulich wrote:
> >>> On 30.10.14 at 03:21, <roy.franz@linaro.org> wrote:
> > So the open question is, when booted from GRUB (or other bootloader),
> > should Xen get it's commandline via the EFI
> > commandline, or via the MB2 protocol?  (and for arm64, this means the
> > FDT based multiboot.)  I felt that the shared code
> > in GRUB was a reasonable reason to follow what Linux did in the EFI case.

Isn't the "unshared" code here an if statement (or maybe two)? I don't
see why this one difference would require a troublesome amount of
separation the implementations.

> Consistency would call for MB2/FDT, but in the end this can very well
> be arch-specific imo (but in that case the patch also needs to reflect
> this).

I don't have a strong opinion either way, but if it is to change for
arm64 I'd like to see a proposed update to
http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot
as a starting point for deciding.

It needs to be careful not to break the "multiboot as a series of u-boot
fdt commands" case too.

Ian.