From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] blktap: CONFIG_GCRYPT detection Date: Tue, 4 Nov 2014 10:48:25 +0000 Message-ID: <1415098105.11486.20.camel@citrix.com> References: <1414499721-1100-1-git-send-email-mpohlack@amazon.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xlbf4-0005m8-8z for xen-devel@lists.xenproject.org; Tue, 04 Nov 2014 10:48:31 +0000 In-Reply-To: <1414499721-1100-1-git-send-email-mpohlack@amazon.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Martin Pohlack , Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Tue, 2014-10-28 at 13:35 +0100, Martin Pohlack wrote: > Wrap make variable in () to allow correct evaluation. > > This fixes broken CONFIG_GCRYPT detection which was introduced by > commit 85896a7c4dc7b6b1dba2db79dfb0ca61738a92a4 in 2012. > > Signed-off-by: Martin Pohlack > Reviewed-by: Uwe Dannowski > Reviewed-by: Anthony Liguori > Reviewed-by: Matt Wilson Acked-by: Ian Campbell You didn't mention if you considered this 4.5 material, but I think it is a pretty obvious/safe bugfix so I've applied it. > --- > tools/blktap/drivers/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/blktap/drivers/Makefile b/tools/blktap/drivers/Makefile > index 7461a95..cea8b3b 100644 > --- a/tools/blktap/drivers/Makefile > +++ b/tools/blktap/drivers/Makefile > @@ -11,7 +11,7 @@ CFLAGS += $(CFLAGS_libxenctrl) > CFLAGS += $(CFLAGS_libxenstore) > CFLAGS += -D_GNU_SOURCE > > -ifeq ($CONFIG_GCRYPT,y) > +ifeq ($(CONFIG_GCRYPT),y) > CFLAGS += -DUSE_GCRYPT > CRYPT_LIB := -lgcrypt > else