From: Ian Campbell <Ian.Campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com
Subject: Re: [PATCH] tools: remove blktap1
Date: Tue, 4 Nov 2014 11:54:26 +0000 [thread overview]
Message-ID: <1415102066.11486.36.camel@citrix.com> (raw)
In-Reply-To: <1415101967-9844-1-git-send-email-ian.campbell@citrix.com>
On Tue, 2014-11-04 at 11:52 +0000, Ian Campbell wrote:
> This was disabled by default in Xen 4.4. Since xend has now been removed from
> the tree I don't believe anything is using it.
>
> We need to pass an explicit CONFIG_BLKTAP1=n to qemu-xen-traditional otherwise
> it defaults to y and doesn't build.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
I suspect this might be too large for the list so it also at
git://xenbits.xen.org/people/ianc/xen.git remove-blktap1
I've trimmed everything but the diffstat from below.
> ---
> I think this has probably missed the boat for 4.5 and there isn't much harm in
> waiting for 4.6. I'm open to being told otherwise though ;-)
> ---
> .gitignore | 5 -
> .hgignore | 5 -
> INSTALL | 1 -
> config/Tools.mk.in | 1 -
> tools/Makefile | 2 +-
> tools/blktap/Makefile | 13 -
> tools/blktap/README | 122 --
> tools/blktap/drivers/Makefile | 73 --
> tools/blktap/drivers/aes.c | 1319 -------------------
> tools/blktap/drivers/aes.h | 28 -
> tools/blktap/drivers/blk.h | 3 -
> tools/blktap/drivers/blk_linux.c | 42 -
> tools/blktap/drivers/blktapctrl.c | 937 -------------
> tools/blktap/drivers/blktapctrl.h | 36 -
> tools/blktap/drivers/blktapctrl_linux.c | 89 --
> tools/blktap/drivers/block-aio.c | 259 ----
> tools/blktap/drivers/block-qcow.c | 1434 --------------------
> tools/blktap/drivers/block-qcow2.c | 2098 ------------------------------
> tools/blktap/drivers/block-ram.c | 295 -----
> tools/blktap/drivers/block-sync.c | 242 ----
> tools/blktap/drivers/block-vmdk.c | 428 ------
> tools/blktap/drivers/bswap.h | 178 ---
> tools/blktap/drivers/img2qcow.c | 282 ----
> tools/blktap/drivers/qcow-create.c | 130 --
> tools/blktap/drivers/qcow2raw.c | 348 -----
> tools/blktap/drivers/tapaio.c | 357 -----
> tools/blktap/drivers/tapaio.h | 108 --
> tools/blktap/drivers/tapdisk.c | 872 -------------
> tools/blktap/drivers/tapdisk.h | 259 ----
> tools/blktap/lib/Makefile | 60 -
> tools/blktap/lib/blkif.c | 185 ---
> tools/blktap/lib/blktaplib.h | 240 ----
> tools/blktap/lib/list.h | 59 -
> tools/blktap/lib/xenbus.c | 617 ---------
> tools/blktap/lib/xs_api.c | 360 -----
> tools/blktap/lib/xs_api.h | 50 -
> tools/configure | 29 +-
> tools/configure.ac | 4 +-
> tools/hotplug/Linux/Makefile | 1 -
> tools/hotplug/Linux/blktap | 94 --
> tools/hotplug/Linux/xen-backend.rules.in | 2 -
> 41 files changed, 3 insertions(+), 11664 deletions(-)
> delete mode 100644 tools/blktap/Makefile
> delete mode 100644 tools/blktap/README
> delete mode 100644 tools/blktap/drivers/Makefile
> delete mode 100644 tools/blktap/drivers/aes.c
> delete mode 100644 tools/blktap/drivers/aes.h
> delete mode 100644 tools/blktap/drivers/blk.h
> delete mode 100644 tools/blktap/drivers/blk_linux.c
> delete mode 100644 tools/blktap/drivers/blktapctrl.c
> delete mode 100644 tools/blktap/drivers/blktapctrl.h
> delete mode 100644 tools/blktap/drivers/blktapctrl_linux.c
> delete mode 100644 tools/blktap/drivers/block-aio.c
> delete mode 100644 tools/blktap/drivers/block-qcow.c
> delete mode 100644 tools/blktap/drivers/block-qcow2.c
> delete mode 100644 tools/blktap/drivers/block-ram.c
> delete mode 100644 tools/blktap/drivers/block-sync.c
> delete mode 100644 tools/blktap/drivers/block-vmdk.c
> delete mode 100644 tools/blktap/drivers/bswap.h
> delete mode 100644 tools/blktap/drivers/img2qcow.c
> delete mode 100644 tools/blktap/drivers/qcow-create.c
> delete mode 100644 tools/blktap/drivers/qcow2raw.c
> delete mode 100644 tools/blktap/drivers/tapaio.c
> delete mode 100644 tools/blktap/drivers/tapaio.h
> delete mode 100644 tools/blktap/drivers/tapdisk.c
> delete mode 100644 tools/blktap/drivers/tapdisk.h
> delete mode 100644 tools/blktap/lib/Makefile
> delete mode 100644 tools/blktap/lib/blkif.c
> delete mode 100644 tools/blktap/lib/blktaplib.h
> delete mode 100644 tools/blktap/lib/list.h
> delete mode 100644 tools/blktap/lib/xenbus.c
> delete mode 100644 tools/blktap/lib/xs_api.c
> delete mode 100644 tools/blktap/lib/xs_api.h
> delete mode 100644 tools/hotplug/Linux/blktap
next prev parent reply other threads:[~2014-11-04 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 11:52 [PATCH] tools: remove blktap1 Ian Campbell
2014-11-04 11:54 ` Ian Campbell [this message]
2014-11-04 13:33 ` David Vrabel
2014-11-04 17:32 ` Konrad Rzeszutek Wilk
2014-11-04 18:07 ` Andrew Cooper
2014-11-04 18:42 ` Is: Discussion about doing it in Xen 4.5 or Xen 4.6 Was:Re: " Konrad Rzeszutek Wilk
2014-11-04 18:45 ` Andrew Cooper
2014-11-04 20:00 ` Konrad Rzeszutek Wilk
2014-11-05 9:20 ` Ian Campbell
2014-11-05 18:16 ` Konrad Rzeszutek Wilk
2014-11-05 18:21 ` George Dunlap
2014-11-12 15:47 ` Shriram Rajagopalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415102066.11486.36.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).