From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian.Campbell@citrix.com, JBeulich@suse.com
Subject: [OSSTEST PATCH 1/2] poll_loop: Restore diversion of logm
Date: Tue, 4 Nov 2014 17:36:50 +0000 [thread overview]
Message-ID: <1415122612-5714-1-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <21593.3655.232310.365186@mariner.uk.xensource.com>
poll_loop is supposed to divert the logging away so that you don't
have to see a pile of repetitive logging if the operation succeeds.
But this was broken when the code was moved from the perl module
Osstest to Osstest::TestSupport. Fix it.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
Osstest/TestSupport.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 1d77933..ef2a853 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -611,7 +611,7 @@ sub poll_loop ($$$&) {
$logmtmpfile= IO::File::new_tmpfile or die $!;
if (!eval {
- local ($Osstest::logm_handle) = ($logmtmpfile);
+ local ($Osstest::TestSupport::logm_handle) = ($logmtmpfile);
$bad= $code->();
1;
}) {
--
1.7.10.4
next prev parent reply other threads:[~2014-11-04 17:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 17:43 [xen-unstable test] 31315: regressions - FAIL xen.org
2014-11-03 10:16 ` Jan Beulich
2014-11-03 10:34 ` Ian Campbell
2014-11-04 17:35 ` Ian Jackson
2014-11-04 17:36 ` Ian Jackson [this message]
2014-11-04 17:36 ` [OSSTEST PATCH 2/2] osstest-confirm-booted: Log processes Ian Jackson
2014-11-05 9:25 ` [xen-unstable test] 31315: regressions - FAIL Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415122612-5714-1-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).