From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 for 4.5] xen/arm: Add support for GICv3 for domU Date: Wed, 5 Nov 2014 10:25:24 +0000 Message-ID: <1415183124.11486.76.camel@citrix.com> References: <1414872625-2961-1-git-send-email-julien.grall@linaro.org> <20141103163904.GF1638@laptop.dumpdata.com> <54590C48.4080100@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XlxmM-0001tG-04 for xen-devel@lists.xenproject.org; Wed, 05 Nov 2014 10:25:30 +0000 In-Reply-To: <54590C48.4080100@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Wei Liu , Vijay Kilari , Stefano Stabellini , Ian Jackson , Vijaya Kumar K , Tim Deegan , Stefano Stabellini , Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf List-Id: xen-devel@lists.xenproject.org On Tue, 2014-11-04 at 17:26 +0000, Julien Grall wrote: > Hi Konrad, > > On 11/03/2014 04:39 PM, Konrad Rzeszutek Wilk wrote: > > On Mon, Nov 03, 2014 at 06:07:33PM +0530, Vijay Kilari wrote: > >> On Mon, Nov 3, 2014 at 4:31 PM, Stefano Stabellini > >> wrote: > >>> On Sat, 1 Nov 2014, Julien Grall wrote: > >>>> The vGIC will emulate the same version as the hardware. The toolstack has > >>>> to retrieve the version of the vGIC in order to be able to create the > >>>> corresponding device tree node. > >>>> > >>>> A new DOMCTL has been introduced for ARM to configure the domain. For now > >>>> it only allow the toolstack to retrieve the version of vGIC. > >>>> This DOMCTL will be extend later to let the user choose the version of the > >>>> emulated GIC. > >>>> > >>>> Signed-off-by: Vijaya Kumar K > >>>> Signed-off-by: Julien Grall > >>>> Cc: Ian Jackson > >>>> Cc: Jan Beulich > >>>> Cc: Daniel De Graaf > >>>> Cc: Wei Liu > >>> > >>> Reviewed-by: Stefano Stabellini > >> > >> Tested with GICv3 platform. > > > > Thank you for doing that. > > > > It also needs Acks from Daniel and Jan. > > This patch doesn't modify the x86 part. So I'm not sure if Jan ack is > required. Would Ian C. ack be enough? Jan had comments on a previous iteration and adding a new domctl (or hypercalls generally) could do with eyes from all arches even if they are currently arch specific, so it would be good to know that he at least doesn't object. > Anyway, Jan do you have any objection on this patch? > > Regards, >