From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCHv2 net-next] xen-netback: remove
 unconditional __pskb_pull_tail() in guest Tx path
Date: Wed, 5 Nov 2014 11:20:05 +0000
Message-ID: <1415186405.15317.6.camel@citrix.com>
References: <1415184622-19421-1-git-send-email-david.vrabel@citrix.com>
	<1415185172.15200.0.camel@citrix.com>
	<9AAE0902D5BC7E449B7C8E4E778ABCD01114238B@AMSPEX01CL01.citrite.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XlydG-0005Wy-Q2
	for xen-devel@lists.xenproject.org; Wed, 05 Nov 2014 11:20:10 +0000
In-Reply-To: <9AAE0902D5BC7E449B7C8E4E778ABCD01114238B@AMSPEX01CL01.citrite.net>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Malcolm Crossley <malcolm.crossley@citrix.com>, Wei Liu <wei.liu2@citrix.com>, David Vrabel <david.vrabel@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-11-05 at 11:17 +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Ian Campbell
> > Sent: 05 November 2014 11:00
> > To: David Vrabel
> > Cc: xen-devel@lists.xenproject.org; Wei Liu; Malcolm Crossley; Paul Durrant
> > Subject: Re: [PATCHv2 net-next] xen-netback: remove unconditional
> > __pskb_pull_tail() in guest Tx path
> > 
> > Dropping netdev since this isn't relevant to them, adding Paul
> > 
> > On Wed, 2014-11-05 at 10:50 +0000, David Vrabel wrote:
> > > - performance: Netback has already grant copied up-to 128 bytes from
> > >   the first slot of a packet into the linear area. The first slot
> > >   normally contain all the IPv4/IPv6 and TCP/UDP headers.
> > 
> > Does "normally" include guests other than Linux? I thought Windows in
> > particular was prone to splitting the headers into a frag per layer or
> > thereabouts?
> > 
> 
> Current upstream Windows PV drivers will put all parsed headers in the
> first frag and the rest of the packet in subsequent flags. The parser
> currently knows about TCP and UDP over IPv4 or v6, with and without
> SNAP encapsulation. It doesn't, for example, know about ARP so the
> backend will see only the ethernet header in the first frag.

Sounds like that is sufficient to reach the "normally" qualification,
thanks.

(I wonder what sort of benefit parsing arp would bring...)

Ian.