From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2 for 4.5] xen/arm: Add support for GICv3
	for domU
Date: Wed, 5 Nov 2014 11:20:46 +0000
Message-ID: <1415186446.15317.7.camel@citrix.com>
References: <1414872625-2961-1-git-send-email-julien.grall@linaro.org>
	<1415183041.11486.74.camel@citrix.com>
	<alpine.DEB.2.02.1411051029370.22875@kaball.uk.xensource.com>
	<1415184967.11486.84.camel@citrix.com>
	<alpine.DEB.2.02.1411051102020.22875@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1Xlydx-0005eJ-VL
	for xen-devel@lists.xenproject.org; Wed, 05 Nov 2014 11:20:54 +0000
In-Reply-To: <alpine.DEB.2.02.1411051102020.22875@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, Julien Grall <julien.grall@linaro.org>, tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-11-05 at 11:02 +0000, Stefano Stabellini wrote:
> On Wed, 5 Nov 2014, Ian Campbell wrote:
> > On Wed, 2014-11-05 at 10:31 +0000, Stefano Stabellini wrote:
> > > On Wed, 5 Nov 2014, Ian Campbell wrote:
> > > > > +         * hardware GIC. Only the value XEN_DOMCTL_CONFIG_GIC_DEFAULT
> > > > > +         * is allowed. The DOMCTL will return the actual version of the
> > > > > +         * GIC.
> > > > > +         */
> > > > > +        if ( domctl->u.configuredomain.gic_version != XEN_DOMCTL_CONFIG_GIC_DEFAULT )
> > > > > +            return -EOPNOTSUPP;
> > > > 
> > > > EOPNOTSUPP doesn't seem quite right. EPARM  or EINVAL perhaps?
> > > > 
> > > > I'm also tempted to suggest that we should accept gic_version == the hw
> > > > value, i.e. by moping the switch below up and including
> > > >         && domctl->u.configuredomain.gic_version != gic_version
> > > > in the condition.
> > > 
> > > I suggested to use -EOPNOTSUPP because one day we want to be able to use
> > > this hypercall to choose a specific gic_version for the guest domain,
> > > including gicv2 on gicv3 hardware for example.
> > 
> > Why is EOPNOTSUPP an appropriate error code for that though?
> 
> Because at the moment we don't support this use case? If we did we would
> be OK with the user passing gic_version = 2 for example.

Ah, I suggested separately in the review we should just accept the g/w
version.

Ian.