From: Ian Campbell <Ian.Campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Bastian Blank <waldi@debian.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] tools: libxl: link libxlu against libxl.
Date: Tue, 6 Jan 2015 11:44:31 +0000 [thread overview]
Message-ID: <1420544671.28863.153.camel@citrix.com> (raw)
In-Reply-To: <20141217205455.GB1829@laptop.dumpdata.com>
On Wed, 2014-12-17 at 15:54 -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 15, 2014 at 10:02:31AM +0000, Ian Campbell wrote:
> > On Mon, 2014-08-04 at 10:58 +0100, Ian Campbell wrote:
> >
> > Ping again. This issue has resurfaced in the Debian packaging of the 4.5
> > rcs. I think we should fix this for 4.5, the risks are minimal.
>
> Ah, the patch did not have 'for-xen-4.5' in it :-P
>
> >
> > > It uses libxl_defbool_set and must therefore be linked against the
> > > right library.
> > >
> > > Spotted by dpkg-shlibdeps and pointed out by Bastian Blank:
> > >
> > > dpkg-shlibdeps: warning: symbol libxl_defbool_set used by debian/libxen-4.4/usr/lib/libxlutil-4.4.so found in none of the libraries
> > >
> > > This required switching the make rule from $^ to an explicit
> > > LIBXLU_OBJS since the former now includes libxenlight.so.
> > >
> > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > > Cc: Bastian Blank <waldi@debian.org>
>
> Shouldn't this be 'Reported-by: "
>
> Anyhow,
>
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Applied.
prev parent reply other threads:[~2015-01-06 11:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 9:58 [PATCH] tools: libxl: link libxlu against libxl Ian Campbell
2014-09-04 13:44 ` Ian Campbell
2014-12-15 10:02 ` Ian Campbell
2014-12-17 20:54 ` Konrad Rzeszutek Wilk
2014-12-18 10:25 ` Ian Campbell
2014-12-18 10:47 ` Wei Liu
2015-01-06 11:44 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420544671.28863.153.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=waldi@debian.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).