From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools: libxl: link libxlu against libxl. Date: Tue, 6 Jan 2015 11:44:31 +0000 Message-ID: <1420544671.28863.153.camel@citrix.com> References: <321a64dc64db335460b51becfc040f4cb0e84a9e.1407146305.git.ian.campbell@citrix.com> <1418637751.16425.64.camel@citrix.com> <20141217205455.GB1829@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141217205455.GB1829@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Bastian Blank , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2014-12-17 at 15:54 -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Dec 15, 2014 at 10:02:31AM +0000, Ian Campbell wrote: > > On Mon, 2014-08-04 at 10:58 +0100, Ian Campbell wrote: > > > > Ping again. This issue has resurfaced in the Debian packaging of the 4.5 > > rcs. I think we should fix this for 4.5, the risks are minimal. > > Ah, the patch did not have 'for-xen-4.5' in it :-P > > > > > > It uses libxl_defbool_set and must therefore be linked against the > > > right library. > > > > > > Spotted by dpkg-shlibdeps and pointed out by Bastian Blank: > > > > > > dpkg-shlibdeps: warning: symbol libxl_defbool_set used by debian/libxen-4.4/usr/lib/libxlutil-4.4.so found in none of the libraries > > > > > > This required switching the make rule from $^ to an explicit > > > LIBXLU_OBJS since the former now includes libxenlight.so. > > > > > > Signed-off-by: Ian Campbell > > > Cc: Bastian Blank > > Shouldn't this be 'Reported-by: " > > Anyhow, > > Release-Acked-by: Konrad Rzeszutek Wilk Applied.