Re: [PATCH] xen/balloon: cancel ballooning if adding new memory failed

[Ian Campbell <Ian.Campbell@citrix.com>]

On Fri, 2015-01-30 at 11:53 +0000, David Vrabel wrote:
> On 30/01/15 11:34, Ian Campbell wrote:
> > On Thu, 2015-01-29 at 18:01 +0000, David Vrabel wrote:
> >> On 29/01/15 13:36, Ian Campbell wrote:
> >>> On Mon, 2014-09-01 at 18:52 +0100, David Vrabel wrote:
> >>>> If the balloon driver is adding additional memory regions to the
> >>>> balloon and add_memory() fails it will likely continuously fail so
> >>>> cancel the balloon operation.
> >>>>
> >>>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> >>>
> >>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776448 and
> >>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1304001 seem to
> >>> suggest this should be a candidate for stable backports?
> >>
> >> It's up to the distro kernel maintainer to request it if they think it
> >> is important.
> > 
> > Which is what I thought I was doing. Surely you don't think I should
> > just ask stable@ without conferring with the relevant maintainers first?
> 
> This fix doesn't even remotely qualify for stable.  As
> stable_kernel_rules.txt says "In short, something critical."

Two people can selectively quote from rules.txt: "It must fix a real bug
that bothers people" and from the bug "And they keep repeating forever,
quite frequently.", seems like a good enough reason to me.

> You are of course free to send the request to stable@ yourself if you
> disagree.

I've found your immediately dismissive attitude here quite off-putting
and unnecessary. Of course it is completely reasonable of me to
highlight a potential backport to the maintainers and the people CCd on
the original patch.

Ian.