From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] xen/balloon: cancel ballooning if adding
 new memory failed
Date: Fri, 30 Jan 2015 12:03:46 +0000
Message-ID: <1422619426.12551.15.camel@citrix.com>
References: <1409593964-15144-1-git-send-email-david.vrabel@citrix.com>
	<1422538593.5198.1.camel@citrix.com> <54CA7580.4090409@citrix.com>
	<1422617642.12551.10.camel@citrix.com> <54CB70CC.8080706@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YHAIg-0005Mj-SU
	for xen-devel@lists.xenproject.org; Fri, 30 Jan 2015 12:03:50 +0000
In-Reply-To: <54CB70CC.8080706@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Daniel Kiper <daniel.kiper@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-01-30 at 11:53 +0000, David Vrabel wrote:
> On 30/01/15 11:34, Ian Campbell wrote:
> > On Thu, 2015-01-29 at 18:01 +0000, David Vrabel wrote:
> >> On 29/01/15 13:36, Ian Campbell wrote:
> >>> On Mon, 2014-09-01 at 18:52 +0100, David Vrabel wrote:
> >>>> If the balloon driver is adding additional memory regions to the
> >>>> balloon and add_memory() fails it will likely continuously fail so
> >>>> cancel the balloon operation.
> >>>>
> >>>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> >>>
> >>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776448 and
> >>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1304001 seem to
> >>> suggest this should be a candidate for stable backports?
> >>
> >> It's up to the distro kernel maintainer to request it if they think it
> >> is important.
> > 
> > Which is what I thought I was doing. Surely you don't think I should
> > just ask stable@ without conferring with the relevant maintainers first?
> 
> This fix doesn't even remotely qualify for stable.  As
> stable_kernel_rules.txt says "In short, something critical."

Two people can selectively quote from rules.txt: "It must fix a real bug
that bothers people" and from the bug "And they keep repeating forever,
quite frequently.", seems like a good enough reason to me.

> You are of course free to send the request to stable@ yourself if you
> disagree.

I've found your immediately dismissive attitude here quite off-putting
and unnecessary. Of course it is completely reasonable of me to
highlight a potential backport to the maintainers and the people CCd on
the original patch.

Ian.