xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: xen-devel@lists.xenproject.org, Ian.Campbell@citrix.com,
	ian.jackson@eu.citrix.com, wei.liu2@citrix.com
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH 3/4] libxl: vcpuset: Remove useless limit on max_vcpus.
Date: Mon,  2 Feb 2015 15:47:48 -0500	[thread overview]
Message-ID: <1422910069-15760-4-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1422910069-15760-1-git-send-email-konrad.wilk@oracle.com>

The check is superflous. If the 'max_vcpus' (argument
value) is greater than  pCPU and --ignore-host has not
been supplied we would print an warning and return
and not call this code.

If the --ignore-host parameter had been used we would
never end up in this condition and enforce 'max_vcpus'.

The only time it would be invoked is if max_vcpus < host_cpu
in which case it would set max_vcpus to max_vcpus.

In short - it is dead code.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 tools/libxl/xl_cmdimpl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index d22ba85..9e2d1b2 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -5053,8 +5053,6 @@ static int vcpuset(uint32_t domid, const char* nr_vcpus, int check_host)
                     " continue\n", host_cpu, max_vcpus);
             return -ERROR_INVAL;
         }
-        /* NB: This also limits how many are set in the bitmap */
-        max_vcpus = (max_vcpus > host_cpu ? host_cpu : max_vcpus);
     }
     rc = libxl_cpu_bitmap_alloc(ctx, &cpumap, max_vcpus);
     if (rc) {
-- 
1.8.4.2

  parent reply	other threads:[~2015-02-02 20:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 13:33 [PATCH v1] Misc fixes to libxl (v1) Konrad Rzeszutek Wilk
2014-06-04 13:33 ` [PATCH v1 1/2] libxl: give pciback a chance to do its teardown before we reset the device Konrad Rzeszutek Wilk
2014-06-05 10:58   ` Ian Campbell
2014-06-05 17:41     ` Konrad Rzeszutek Wilk
2014-06-05 17:56       ` Ian Jackson
2014-06-06  9:07         ` Ian Campbell
2014-06-04 13:33 ` [PATCH v1 2/2] libxl: vcpu-set - allow to decrease vcpu count on overcommitted guests (v2) Konrad Rzeszutek Wilk
2014-06-05 11:02   ` Ian Campbell
2014-06-05 17:44     ` Konrad Rzeszutek Wilk
2014-06-06  9:07       ` Ian Campbell
2015-02-02 20:47         ` Konrad Rzeszutek Wilk
2015-02-02 20:47           ` [PATCH 1/4] libxl: vcpuset: Return error values Konrad Rzeszutek Wilk
2015-02-03 11:29             ` Ian Jackson
2015-02-02 20:47           ` [PATCH 2/4] libxl: vcpuset: Check max_vcpus argument against the maximum number of vCPUs the guest has set Konrad Rzeszutek Wilk
2015-02-03 15:11             ` Ian Jackson
2015-02-03 15:45               ` Konrad Rzeszutek Wilk
2015-03-11 10:56                 ` Ian Campbell
2015-02-02 20:47           ` Konrad Rzeszutek Wilk [this message]
2015-02-02 20:47           ` [PATCH 4/4] libxl: vcpu-set - allow to decrease vcpu count on overcommitted guests (v3) Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422910069-15760-4-git-send-email-konrad.wilk@oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).