From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: jfehlig@suse.com, Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST 03/12] osstest migrate support check catch -> variables
Date: Wed, 11 Mar 2015 16:15:58 +0000 [thread overview]
Message-ID: <1426090558.21353.305.camel@citrix.com> (raw)
In-Reply-To: <1423480206-9729-4-git-send-email-wei.liu2@citrix.com>
On Mon, 2015-02-09 at 11:09 +0000, Wei Liu wrote:
> From: Ian Jackson <Ian.Jackson@eu.citrix.com>
I remember the f2f discussion around this, but I cannot remember what
this is actually supposed to do. Can you? If so could you write it down
please ;-)
>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
> sg-run-job | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sg-run-job b/sg-run-job
> index 2cf810a..cc2ab3b 100755
> --- a/sg-run-job
> +++ b/sg-run-job
> @@ -289,7 +289,9 @@ proc run-job/test-pair {} {
> }
>
> proc test-guest-migr {g} {
> - if {[catch { run-ts . = ts-migrate-support-check + host $g }]} return
> + set to_reap [spawn-ts . = ts-migrate-support-check + host $g]
> + set can_migrate [reap-ts $to_reap]
> + if {!$can_migrate} return
>
> foreach iteration {{} .2} {
> run-ts . =$iteration ts-guest-saverestore + host $g
next prev parent reply other threads:[~2015-03-11 16:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 11:09 [PATCH OSSTEST 00/12] Libvirt save, restore and migration support Wei Liu
2015-02-09 11:09 ` [PATCH OSSTEST 01/12] toolstack: save / restore check Wei Liu
2015-03-11 16:14 ` Ian Campbell
2015-02-09 11:09 ` [PATCH OSSTEST 02/12] Introduce ts-saverestore-support-check Wei Liu
2015-03-11 16:14 ` Ian Campbell
2015-02-09 11:09 ` [PATCH OSSTEST 03/12] osstest migrate support check catch -> variables Wei Liu
2015-03-11 16:15 ` Ian Campbell [this message]
2015-02-09 11:09 ` [PATCH OSSTEST 04/12] toolstack: distinguish local and remote migration support Wei Liu
2015-03-11 16:18 ` Ian Campbell
2015-03-25 21:18 ` Jim Fehlig
2015-03-26 10:02 ` Ian Campbell
2015-02-09 11:09 ` [PATCH OSSTEST 05/12] sg-run-job: remove save/restore dependency on local " Wei Liu
2015-03-11 16:27 ` Ian Campbell
2015-02-09 11:10 ` [PATCH OSSTEST 06/12] toolstack/libvirt: guest migrate, save and restore support Wei Liu
2015-03-11 16:27 ` Ian Campbell
2015-02-09 11:10 ` [PATCH OSSTEST 07/12] ts-xen-build-prep: install ebtables Wei Liu
2015-03-11 16:28 ` Ian Campbell
2015-02-09 11:10 ` [PATCH OSSTEST 08/12] ts-libvirt-build: run libvirt test suite Wei Liu
2015-03-11 16:31 ` Ian Campbell
2015-07-11 15:16 ` Wei Liu
2015-02-09 11:10 ` [PATCH OSSTEST 09/12] ts-debian-hvm-install: stub out libvirt + ovmf / rombios Wei Liu
2015-03-11 16:32 ` Ian Campbell
2015-03-11 16:34 ` Ian Campbell
2015-07-10 14:53 ` Wei Liu
2015-02-09 11:10 ` [PATCH OSSTEST 10/12] make-flight: debian hvm tests with libvirt Wei Liu
2015-03-11 16:36 ` Ian Campbell
2015-07-10 14:54 ` Wei Liu
2015-02-09 11:10 ` [PATCH OSSTEST 11/12] make-flight, mfi-common: rename onetoolstack to pairtoolstack Wei Liu
2015-03-11 16:37 ` Ian Campbell
2015-02-09 11:10 ` [PATCH OSSTEST 12/12] make-flight, mfi-common: create live migration test for libvirt Wei Liu
2015-03-11 16:38 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426090558.21353.305.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=jfehlig@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).