From: Ian Campbell <ian.campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com,
wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 11/14] libxl: If xc_domain_add_to_physmap fails, include errno value
Date: Wed, 18 Mar 2015 16:34:22 +0000 [thread overview]
Message-ID: <1426696462.14291.79.camel@citrix.com> (raw)
In-Reply-To: <1426520383-20855-12-git-send-email-konrad.wilk@oracle.com>
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote:
$subject says libxl but means libxc.
Actually, now I notice it so do almost all of the patches! Once fixed
any acks I gave (or will give shortly) can still be applied.
> Instead of just the return value.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> tools/libxc/xc_dom_x86.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
> index bf06fe4..20e379c 100644
> --- a/tools/libxc/xc_dom_x86.c
> +++ b/tools/libxc/xc_dom_x86.c
> @@ -865,7 +865,8 @@ static int map_grant_table_frames(struct xc_dom_image *dom)
> }
> xc_dom_panic(dom->xch, XC_INTERNAL_ERROR,
> "%s: mapping grant tables failed " "(pfn=0x%" PRIpfn
> - ", rc=%d)", __FUNCTION__, dom->total_pages + i, rc);
> + ", rc=%d, errno=%d)", __FUNCTION__,
> + dom->total_pages + i, rc ,errno);
s/ ,/, /
(hey, I drew a pretty picture)
With that fixed: Acked-by Ian Campbell <ian.campbell@citrix.com>
Ian.
next prev parent reply other threads:[~2015-03-18 16:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 15:39 [PATCH v1] Fix libxc return -E misusage Konrad Rzeszutek Wilk
2015-03-16 15:39 ` [PATCH 01/14] libxc: Replaces tabs with spaces in xc_cpupool_freeinfo Konrad Rzeszutek Wilk
2015-03-18 16:13 ` Ian Campbell
2015-03-16 15:39 ` [PATCH 02/14] libxl: Propagate errno from hypercall instead of anything else Konrad Rzeszutek Wilk
2015-03-18 16:17 ` Ian Campbell
2015-03-16 15:39 ` [PATCH 03/14] libxc: xc_core_arch_memory_map_get populate errno Konrad Rzeszutek Wilk
2015-03-18 16:18 ` Ian Campbell
2015-03-16 15:39 ` [PATCH 04/14] libxc: Fix xc_domain_get_tsc_info to return -1 instead of -Exx Konrad Rzeszutek Wilk
2015-03-18 16:20 ` Ian Campbell
2015-03-16 15:39 ` [PATCH 05/14] libxl: xc_physdev_map return -1 and populate errno Konrad Rzeszutek Wilk
2015-03-18 16:21 ` Ian Campbell
2015-03-18 16:29 ` Konrad Rzeszutek Wilk
2015-03-16 15:39 ` [PATCH 06/14] libxl: Return negative value and propagate errno for xc_offline_page API Konrad Rzeszutek Wilk
2015-03-18 16:22 ` Ian Campbell
2015-03-16 15:39 ` [PATCH 07/14] libxl: Fix xc_pm API calls to return negative error and stash error in errno Konrad Rzeszutek Wilk
2015-03-18 16:23 ` Ian Campbell
2015-03-16 15:39 ` [PATCH 08/14] libxl: Fix xc_tmem_control to return proper error Konrad Rzeszutek Wilk
2015-03-18 16:26 ` Ian Campbell
2015-03-18 17:37 ` Konrad Rzeszutek Wilk
2015-03-19 10:26 ` Ian Campbell
2015-03-16 15:39 ` [PATCH 09/14] libxl: Check xc_domain_maximum_gpfn for negative return values Konrad Rzeszutek Wilk
2015-03-18 16:30 ` Ian Campbell
2015-03-16 15:39 ` [PATCH 10/14] libxl: Check xc_maximum_ram_page " Konrad Rzeszutek Wilk
2015-03-18 16:32 ` Ian Campbell
2015-03-16 15:39 ` [PATCH 11/14] libxl: If xc_domain_add_to_physmap fails, include errno value Konrad Rzeszutek Wilk
2015-03-18 16:34 ` Ian Campbell [this message]
2015-03-16 15:39 ` [PATCH 12/14] libxl: Check xc_sharing_* for proper return values Konrad Rzeszutek Wilk
2015-03-18 16:36 ` Ian Campbell
2015-03-18 18:03 ` Konrad Rzeszutek Wilk
2015-03-16 15:39 ` [PATCH 13/14] libxl: Don't assign return value to errno for E820 get/set xc_ calls Konrad Rzeszutek Wilk
2015-03-18 16:37 ` Ian Campbell
2015-03-16 15:39 ` [PATCH 14/14] libxl: Fix do_memory_op to return negative value on errors Konrad Rzeszutek Wilk
2015-03-18 16:39 ` Ian Campbell
2015-03-18 16:43 ` [PATCH v1] Fix libxc return -E misusage Ian Campbell
2015-03-18 18:19 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426696462.14291.79.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox