From: Ian Campbell <ian.campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: george.dunlap@eu.citrix.com, xen-devel@lists.xenproject.org,
Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v3 1/3] libxl/cpumap: Add xc_cpumap_[setcpu, clearcpu, testcpu] to complement xc_cpumap_alloc.
Date: Tue, 24 Mar 2015 17:46:04 +0000 [thread overview]
Message-ID: <1427219164.10784.7.camel@citrix.com> (raw)
In-Reply-To: <1427211559-15185-2-git-send-email-konrad.wilk@oracle.com>
On Tue, 2015-03-24 at 11:39 -0400, Konrad Rzeszutek Wilk wrote:
Please make sure you CC all of the toolstack maintainers.
> +void xc_cpumap_clearcpu(int cpu, xc_cpumap_t map)
> +{
> + clear_bit(cpu, (unsigned long *)map);
Is it necessary to worry about alignment here, since xc_cpumap_t is
actually a uint8_t*.
I'm afraid I think it probably is on ARM at least, which is rather
tedious.
Or do we rely on all of these always being dynamically allocated (via
xc_cpumap_alloc) and therefore "suitably aligned so that it may be
assigned to a pointer to any type of object"[0] following calloc ,
avoids the issue in practice?
I think we probably do, does anyone disagree with that assessment?
Ian.
[0]
http://pubs.opengroup.org/onlinepubs/9699919799/functions/calloc.html#tag_16_39
next prev parent reply other threads:[~2015-03-24 17:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 15:39 [PATCH v3] Support CPU-list parsing in xentrace Konrad Rzeszutek Wilk
2015-03-24 15:39 ` [PATCH v3 1/3] libxl/cpumap: Add xc_cpumap_[setcpu, clearcpu, testcpu] to complement xc_cpumap_alloc Konrad Rzeszutek Wilk
2015-03-24 17:46 ` Ian Campbell [this message]
2015-03-24 20:29 ` Konrad Rzeszutek Wilk
2015-03-25 8:53 ` Dario Faggioli
2015-03-25 17:16 ` Konrad Rzeszutek Wilk
2015-03-25 8:47 ` Dario Faggioli
2015-03-25 11:01 ` Ian Campbell
2015-03-25 11:16 ` Dario Faggioli
2015-03-24 15:39 ` [PATCH v3 2/3] libxc/xentrace: Replace xc_tbuf_set_cpu_mask with CPU mask with xc_cpumap_t instead of uint32_t Konrad Rzeszutek Wilk
2015-03-30 16:10 ` George Dunlap
2015-03-30 16:54 ` Konrad Rzeszutek Wilk
2015-03-30 17:33 ` George Dunlap
2015-03-30 18:04 ` Konrad Rzeszutek Wilk
2015-03-31 10:41 ` George Dunlap
2015-03-24 15:39 ` [PATCH v3 3/3] xentrace: Implement cpu mask range parsing of human values (-c) Konrad Rzeszutek Wilk
2015-03-31 11:31 ` George Dunlap
2015-04-03 19:34 ` Konrad Rzeszutek Wilk
2015-05-07 16:07 ` George Dunlap
2015-05-15 20:17 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427219164.10784.7.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).