From: Dario Faggioli <dario.faggioli@citrix.com>
To: "Justin T. Weaver" <jtweaver@hawaii.edu>
Cc: george.dunlap@eu.citrix.com, henric@hawaii.edu, xen-devel@lists.xen.org
Subject: Re: [PATCH v3 3/4] sched: credit2: indent code sections to make review of patch 4/4 easier
Date: Thu, 23 Apr 2015 17:35:20 +0200 [thread overview]
Message-ID: <1429803320.18926.195.camel@citrix.com> (raw)
In-Reply-To: <1427363314-25430-4-git-send-email-jtweaver@hawaii.edu>
[-- Attachment #1.1: Type: text/plain, Size: 739 bytes --]
On Wed, 2015-03-25 at 23:48 -1000, Justin T. Weaver wrote:
> Functions runq_tickle and choose_cpu both have code sections that get turned
> into loops in patch 4 v3, soft affinity. Do the indenting here to make the
> patch 4 diff section easier to read.
>
Yeah, I know what you mean, an thanks for trying making our job
easier! :-)
Still, it's rather uncommon a thing to do (it's probably the first time
I see it), and I can't call myself a fan of it. So, I'm not sure what
others think, but me, I'd say just drop this patch, and do all the
functional and non-functional changes all at once.
Hopefully, splitting patch4 the way George suggests will make the result
easier to review anyway.
Thanks and Regards,
Dario
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-04-23 15:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 9:48 [PATCH v3 0/4] sched: credit2: introduce per-vcpu hard and soft affinity Justin T. Weaver
2015-03-26 9:48 ` [PATCH v3 1/4] sched: credit2: respect per-vcpu hard affinity Justin T. Weaver
2015-03-31 14:37 ` George Dunlap
2015-03-31 17:14 ` Dario Faggioli
2015-03-31 17:32 ` George Dunlap
2015-04-23 16:00 ` Dario Faggioli
2015-05-06 12:39 ` Dario Faggioli
2015-03-26 9:48 ` [PATCH v3 2/4] sched: factor out per-vcpu affinity related code to common header file Justin T. Weaver
2015-04-23 15:22 ` Dario Faggioli
2015-03-26 9:48 ` [PATCH v3 3/4] sched: credit2: indent code sections to make review of patch 4/4 easier Justin T. Weaver
2015-04-23 15:35 ` Dario Faggioli [this message]
2015-03-26 9:48 ` [PATCH v3 4/4] sched: credit2: consider per-vcpu soft affinity Justin T. Weaver
2015-03-31 17:38 ` George Dunlap
2015-04-20 15:38 ` George Dunlap
2015-04-22 16:16 ` George Dunlap
2015-09-17 14:27 ` [PATCH v3 0/4] sched: credit2: introduce per-vcpu hard and " Dario Faggioli
2015-09-17 15:15 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429803320.18926.195.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=henric@hawaii.edu \
--cc=jtweaver@hawaii.edu \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).