From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: [PATCH] libxl: Initialize valid_devs in output_topologyinfo() Date: Fri, 15 May 2015 11:06:57 -0400 Message-ID: <1431702417-9006-1-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: ian.jackson@eu.citrix.com, ian.campbell@citrix.com, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com Cc: olaf@aepfle.de, boris.ostrovsky@oracle.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Commit e78e8b9bb649 ("libxl: Add interface for querying hypervisor about PCI topology") neglected to initialize valid_devs. This may result in not printing a message to console if no IO topology information is available and, more importantly, may break non-debug builds on some versions of gcc. Signed-off-by: Boris Ostrovsky Reported-by: Olaf Hering --- tools/libxl/xl_cmdimpl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 373aa37..6d60ce4 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -5423,7 +5423,7 @@ static void output_topologyinfo(void) libxl_cputopology *cpuinfo; int i, nr; libxl_pcitopology *pciinfo; - int valid_devs; + int valid_devs = 0; cpuinfo = libxl_get_cpu_topology(ctx, &nr); -- 1.7.1