From: Ian Campbell <ian.campbell@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Charles Arnold <carnold@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] libxl: 'valid_devs' may be used uninitialized
Date: Thu, 21 May 2015 15:52:31 +0100 [thread overview]
Message-ID: <1432219951.10746.59.camel@citrix.com> (raw)
In-Reply-To: <1431711561.2978.182.camel@citrix.com>
On Fri, 2015-05-15 at 19:39 +0200, Dario Faggioli wrote:
> On Fri, 2015-05-15 at 11:06 -0600, Charles Arnold wrote:
> > Using gcc 4.8 to compile with -Werror.
> >
> > xl_cmdimpl.c:5493:8: error: 'valid_devs' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> > if (valid_devs == 0)
> > ^
> > xl_cmdimpl.c:5455:9: note: 'valid_devs' was declared here
> > int valid_devs;
> >
> > Signed-off-by: Charles Arnold <carnold@suse.com>
> >
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked + applied, thanks
prev parent reply other threads:[~2015-05-21 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 17:06 [PATCH] libxl: 'valid_devs' may be used uninitialized Charles Arnold
2015-05-15 17:39 ` Dario Faggioli
2015-05-21 14:52 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432219951.10746.59.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=carnold@suse.com \
--cc=dario.faggioli@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).