From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] libxl: 'valid_devs' may be used
 uninitialized
Date: Thu, 21 May 2015 15:52:31 +0100
Message-ID: <1432219951.10746.59.camel@citrix.com>
References: <5555D31C02000091000F7CC4@prv-mh.provo.novell.com>
	<1431711561.2978.182.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1431711561.2978.182.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Charles Arnold <carnold@suse.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-05-15 at 19:39 +0200, Dario Faggioli wrote:
> On Fri, 2015-05-15 at 11:06 -0600, Charles Arnold wrote:
> > Using gcc 4.8 to compile with -Werror.
> > 
> > xl_cmdimpl.c:5493:8: error: 'valid_devs' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> >       if (valid_devs == 0)
> >          ^
> > xl_cmdimpl.c:5455:9: note: 'valid_devs' was declared here
> >       int valid_devs;
> > 
> > Signed-off-by: Charles Arnold <carnold@suse.com>
> > 
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Acked + applied, thanks