From: "longtao.pang" <longtaox.pang@intel.com>
To: xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com,
Ian.Jackson@eu.citrix.com, Wei.Lui@citrix.com,
robert.hu@intel.com, longtaox.pang@intel.com
Subject: [OSSTEST Nested PATCH v11 1/7] grub: remove patch to disable submenu from 20_linux_xen overlay
Date: Tue, 26 May 2015 17:08:18 +0800 [thread overview]
Message-ID: <1432631304-27347-2-git-send-email-longtaox.pang@intel.com> (raw)
In-Reply-To: <1432631304-27347-1-git-send-email-longtaox.pang@intel.com>
setupboot_grub2 now supports submenus, so we can reduce our delta vs
upstream a bit.
I started by extracting 20_linux_xen from
http://snapshot.debian.org/archive/debian/20130703T094657Z/pool/main/g/grub2/grub-common_1.99-27%2Bdeb7u2_amd64.deb
and then applying the patch at
http://savannah.gnu.org/file/grub.patch?file_id=32276 (the patch from
grub bug #42420 at http://savannah.gnu.org/bugs/?43420) and
reinstating the comment at the top of the file (modified to drop the
reference to the Debian bug.
This left me with some spurious changes:
@@ -93,7 +93,7 @@ linux_entry ()
if test ! -e "${xen_dirname}/${xenpolicy}" ; then
return
fi
- xen_args=`echo $xen_args flask=enforcing`
+ xen_args=`echo $xen_args flask_enabled=1 flask_enforcing=1`
if ${recovery} ; then
title="$(gettext_quoted "%s, with Xen %s (XSM enabled) and
Linux %s (recovery mode)")"
else
@@ -137,7 +137,6 @@ EOF
echo '$message'
module ${rel_dirname}/${xenpolicy}
EOF
- fi
cat << EOF
}
EOF
I think these are bugs in the patch in the grub BTS, which were fixed
while iterating over the XSM series in osstest but didn't make it into
the upstream version, the fixes to those bugs are reverted byu the
above. So I have manually reverted them.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei.Lui@citrix.com
Cc: longtaox.pang@intel.com
---
overlay/etc/grub.d/20_linux_xen | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/overlay/etc/grub.d/20_linux_xen b/overlay/etc/grub.d/20_linux_xen
index 5315e2a..aaead1b 100755
--- a/overlay/etc/grub.d/20_linux_xen
+++ b/overlay/etc/grub.d/20_linux_xen
@@ -1,7 +1,7 @@
#! /bin/sh
# Copied from the identically named file in grub-common 1.99-27+deb7u2.
-# This version fixed Debian bug #690538 and GRUB bug #43420.
+# This version fixes GRUB bug #43420.
set -e
@@ -173,6 +173,7 @@ while [ "x${xen_list}" != "x" ] ; do
xen_dirname=`dirname ${current_xen}`
rel_xen_dirname=`make_system_path_relative_to_its_root $xen_dirname`
xen_version=`echo $xen_basename | sed -e "s,.gz$,,g;s,^xen-,,g"`
+ echo "submenu \"Xen ${xen_version}\" {"
while [ "x$list" != "x" ] ; do
linux=`version_find_latest $list`
echo "Found linux image: $linux" >&2
@@ -214,5 +215,6 @@ while [ "x${xen_list}" != "x" ] ; do
list=`echo $list | tr ' ' '\n' | grep -vx $linux | tr '\n' ' '`
done
+ echo "}"
xen_list=`echo $xen_list | tr ' ' '\n' | grep -vx $current_xen | tr '\n' ' '`
done
--
1.7.10.4
next prev parent reply other threads:[~2015-05-26 9:08 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 9:08 [OSSTEST Nested PATCH v11 0/7] Introduction of netsted HVM test job longtao.pang
2015-05-26 9:08 ` longtao.pang [this message]
2015-05-26 9:08 ` [OSSTEST Nested PATCH v11 2/7] Parsing grub which has 'submenu' primitive longtao.pang
2015-06-10 13:30 ` Ian Jackson
2015-06-11 3:17 ` Robert Hu
2015-06-11 8:37 ` Ian Campbell
2015-06-11 9:01 ` Robert Hu
2015-05-26 9:08 ` [OSSTEST Nested PATCH v11 3/7] Changes to support '/boot' leading paths of kernel, xen, in grub longtao.pang
2015-06-10 13:31 ` Ian Jackson
2015-05-26 9:08 ` [OSSTEST Nested PATCH v11 4/7] Changes on test step of Debian hvm guest install longtao.pang
2015-06-08 10:31 ` Ian Campbell
2015-06-09 5:29 ` Pang, LongtaoX
2015-06-09 8:07 ` Ian Campbell
2015-06-09 9:10 ` Pang, LongtaoX
2015-06-10 13:41 ` Ian Jackson
2015-06-11 6:15 ` Pang, LongtaoX
2015-06-11 15:08 ` Ian Jackson
2015-05-26 9:08 ` [OSSTEST Nested PATCH v11 5/7] Add new script to customize nested test configuration longtao.pang
2015-06-10 13:58 ` Ian Jackson
2015-06-11 6:19 ` Pang, LongtaoX
2015-06-11 15:14 ` Ian Jackson
2015-06-12 3:46 ` Pang, LongtaoX
2015-06-12 8:42 ` Ian Campbell
2015-05-26 9:08 ` [OSSTEST Nested PATCH v11 6/7] Compose the main recipe of nested test job longtao.pang
2015-06-10 15:42 ` Ian Jackson
2015-06-11 7:41 ` Pang, LongtaoX
2015-06-11 8:40 ` Ian Campbell
2015-06-11 9:52 ` Pang, LongtaoX
2015-06-11 10:37 ` Ian Campbell
2015-06-11 15:19 ` Ian Jackson
2015-06-12 3:42 ` Robert Hu
2015-06-12 8:44 ` Ian Campbell
2015-06-12 9:00 ` Robert Hu
2015-06-12 9:15 ` Ian Campbell
2015-06-12 3:58 ` Pang, LongtaoX
2015-06-12 15:27 ` Ian Jackson
2015-06-12 15:28 ` Ian Jackson
2015-06-14 12:52 ` Robert Hu
2015-06-14 12:51 ` Robert Hu
2015-06-15 9:08 ` Ian Campbell
2015-06-17 8:54 ` Pang, LongtaoX
2015-06-17 9:35 ` Ian Campbell
2015-06-17 11:00 ` Pang, LongtaoX
2015-06-17 11:48 ` Ian Campbell
2015-06-18 9:16 ` Pang, LongtaoX
2015-06-18 9:22 ` Ian Campbell
2015-06-18 9:26 ` Pang, LongtaoX
2015-06-17 11:31 ` Ian Jackson
2015-06-25 8:21 ` Pang, LongtaoX
2015-06-25 9:33 ` Ian Campbell
2015-06-25 10:21 ` Ian Jackson
2015-08-18 6:46 ` Hu, Robert
2015-09-01 13:51 ` Ian Campbell
2015-09-01 14:41 ` Ian Jackson
2015-09-01 14:58 ` Ian Campbell
2015-09-11 1:39 ` Hu, Robert
2015-09-11 14:03 ` Ian Jackson
2015-09-11 1:39 ` Hu, Robert
2015-06-17 9:08 ` Pang, LongtaoX
2015-06-19 3:03 ` Pang, LongtaoX
2015-06-19 12:16 ` Ian Jackson
2015-06-19 12:17 ` Ian Jackson
2015-06-30 16:36 ` [OSSTEST RFC PATCH 0/4] Nested job execution infrastructure Ian Jackson
2015-06-30 16:36 ` [OSSTEST PATCH 1/4] Tcl: Provide lunappend Ian Jackson
2015-06-30 16:36 ` [OSSTEST PATCH 2/4] sg-run-job: Declare Tcl (for the benefit of Emacs) Ian Jackson
2015-06-30 16:36 ` [OSSTEST PATCH 3/4] sg-run-job: Break out per-host-prep and per-host-finish Ian Jackson
2015-07-28 5:39 ` Robert Hu
2015-07-28 15:15 ` Ian Jackson
2015-07-29 8:13 ` Robert Hu
2015-06-30 16:36 ` [OSSTEST PATCH 4/4] sg-run-job: Provide infrastructure for layers of nesting Ian Jackson
2015-07-28 6:47 ` Robert Hu
2015-07-28 15:13 ` Ian Jackson
2015-06-30 16:56 ` [OSSTEST RFC PATCH 0/4] Nested job execution infrastructure Ian Jackson
2015-07-01 1:56 ` Robert Hu
2015-07-02 17:14 ` Ian Jackson
2015-07-28 5:36 ` Robert Hu
2015-05-26 9:08 ` [OSSTEST Nested PATCH v11 7/7] Add test job for nest test case longtao.pang
2015-06-10 15:46 ` Ian Jackson
2015-06-11 6:28 ` Pang, LongtaoX
2015-06-11 15:16 ` Ian Jackson
2015-05-26 11:34 ` [OSSTEST Nested PATCH v11 0/7] Introduction of netsted HVM test job Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432631304-27347-2-git-send-email-longtaox.pang@intel.com \
--to=longtaox.pang@intel.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Wei.Lui@citrix.com \
--cc=robert.hu@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).