xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: JBeulich@suse.com, kevin.tian@intel.com,
	suravee.suthikulpanit@amd.com, Aravind.Gopalakrishnan@amd.com,
	dietmar.hahn@ts.fujitsu.com, dgdegra@tycho.nsa.gov,
	andrew.cooper3@citrix.com, jun.nakajima@intel.com, tim@xen.org,
	xen-devel@lists.xen.org
Cc: boris.ostrovsky@oracle.com
Subject: [PATCH v23 07/15] x86/VPMU: Save VPMU state for PV guests during context switch
Date: Fri, 29 May 2015 14:42:52 -0400	[thread overview]
Message-ID: <1432924980-24281-8-git-send-email-boris.ostrovsky@oracle.com> (raw)
In-Reply-To: <1432924980-24281-1-git-send-email-boris.ostrovsky@oracle.com>

Save VPMU state during context switch for both HVM and PV(H) guests.

A subsequent patch ("x86/VPMU: NMI-based VPMU support") will make it possible
for vpmu_switch_to() to call vmx_vmcs_try_enter()->vcpu_pause() which needs
is_running to be correctly set/cleared. To prepare for that, call context_saved()
before vpmu_switch_to() is executed. (Note that while this change could have
been dalayed until that later patch, the changes are harmless to existing code
and so we do it here)

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/domain.c | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index 8e79aca..2b82f61 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -1537,17 +1537,14 @@ void context_switch(struct vcpu *prev, struct vcpu *next)
     }
 
     if ( prev != next )
-        _update_runstate_area(prev);
-
-    if ( is_hvm_vcpu(prev) )
     {
-        if (prev != next)
-            vpmu_switch_from(prev);
-
-        if ( !list_empty(&prev->arch.hvm_vcpu.tm_list) )
-            pt_save_timer(prev);
+        _update_runstate_area(prev);
+        vpmu_switch_from(prev);
     }
 
+    if ( is_hvm_vcpu(prev) && !list_empty(&prev->arch.hvm_vcpu.tm_list) )
+        pt_save_timer(prev);
+
     local_irq_disable();
 
     set_current(next);
@@ -1585,15 +1582,16 @@ void context_switch(struct vcpu *prev, struct vcpu *next)
                            !is_hardware_domain(next->domain));
     }
 
-    if (is_hvm_vcpu(next) && (prev != next) )
-        /* Must be done with interrupts enabled */
-        vpmu_switch_to(next);
-
     context_saved(prev);
 
     if ( prev != next )
+    {
         _update_runstate_area(next);
 
+        /* Must be done with interrupts enabled */
+        vpmu_switch_to(next);
+    }
+
     /* Ensure that the vcpu has an up-to-date time base. */
     update_vcpu_system_time(next);
 
-- 
1.8.1.4

  parent reply	other threads:[~2015-05-29 18:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 18:42 [PATCH v23 00/15] x86/PMU: Xen PMU PV(H) support Boris Ostrovsky
2015-05-29 18:42 ` [PATCH v23 01/15] common/symbols: Export hypervisor symbols to privileged guest Boris Ostrovsky
2015-05-29 18:42 ` [PATCH v23 02/15] x86/VPMU: Add public xenpmu.h Boris Ostrovsky
2015-05-29 18:42 ` [PATCH v23 03/15] x86/VPMU: Make vpmu not HVM-specific Boris Ostrovsky
2015-05-29 18:42 ` [PATCH v23 04/15] x86/VPMU: Interface for setting PMU mode and flags Boris Ostrovsky
2015-05-29 18:42 ` [PATCH v23 05/15] x86/VPMU: Initialize VPMUs with __initcall Boris Ostrovsky
2015-05-29 18:42 ` [PATCH v23 06/15] x86/VPMU: Initialize PMU for PV(H) guests Boris Ostrovsky
2015-05-29 18:42 ` Boris Ostrovsky [this message]
2015-05-29 18:42 ` [PATCH v23 08/15] x86/VPMU: When handling MSR accesses, leave fault injection to callers Boris Ostrovsky
2015-05-29 18:42 ` [PATCH v23 09/15] x86/VPMU: Add support for PMU register handling on PV guests Boris Ostrovsky
2015-05-29 18:42 ` [PATCH v23 10/15] x86/VPMU: Use pre-computed masks when checking validity of MSRs Boris Ostrovsky
2015-06-01 11:07   ` Jan Beulich
2015-05-29 18:42 ` [PATCH v23 11/15] VPMU/AMD: Check MSR values before writing to hardware Boris Ostrovsky
2015-06-05 16:03   ` Jan Beulich
2015-06-05 16:32     ` Boris Ostrovsky
2015-06-08  9:22       ` Jan Beulich
2015-05-29 18:42 ` [PATCH v23 12/15] x86/VPMU: Handle PMU interrupts for PV(H) guests Boris Ostrovsky
2015-06-05 16:09   ` Jan Beulich
2015-06-05 16:38     ` Boris Ostrovsky
2015-05-29 18:42 ` [PATCH v23 13/15] x86/VPMU: Merge vpmu_rdmsr and vpmu_wrmsr Boris Ostrovsky
2015-05-29 18:42 ` [PATCH v23 14/15] x86/VPMU: Add privileged PMU mode Boris Ostrovsky
2015-05-29 18:43 ` [PATCH v23 15/15] x86/VPMU: Move VPMU files up from hvm/ directory Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432924980-24281-8-git-send-email-boris.ostrovsky@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=Aravind.Gopalakrishnan@amd.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=dietmar.hahn@ts.fujitsu.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).