From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: [PATCH 2/2] libxl: clean up qemu-save and qemu-resume files Date: Mon, 1 Jun 2015 18:24:36 +0100 Message-ID: <1433179476-16642-3-git-send-email-wei.liu2@citrix.com> References: <1433179476-16642-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YzTS5-0004cJ-Pz for xen-devel@lists.xenproject.org; Mon, 01 Jun 2015 17:24:41 +0000 In-Reply-To: <1433179476-16642-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: Wei Liu , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org These files are leaked when using qemu-trad stubdom. They are intermediate files created by libxc. Unfortunately they don't fit well in our userdata scheme. Clean them up after we destroy guest, we're sure they are not useful anymore at that point. Signed-off-by: Wei Liu --- tools/libxl/libxl.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 9117b01..ad2290d 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -1686,6 +1686,15 @@ static void devices_destroy_cb(libxl__egc *egc, rc = xc_domain_destroy(ctx->xch, domid); if (rc < 0) goto badchild; + /* Clean up qemu-save and qemu-resume files. They are + * intermediate files created by libxc. Unfortunately they + * don't fit in existing userdata scheme very well. + */ + rc = libxl__remove_file(gc, libxl__device_model_savefile(gc, domid)); + if (rc < 0) goto badchild; + rc = libxl__remove_file(gc, + GCSPRINTF(XC_DEVICE_MODEL_RESTORE_FILE".%u", domid)); + if (rc < 0) goto badchild; _exit(0); badchild: -- 1.9.1