From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v1 4/5] tools/libxl: move toolstack code into libxl_toolstack.c Date: Tue, 2 Jun 2015 15:48:32 +0100 Message-ID: <1433256512.15036.296.camel@citrix.com> References: <1432116090-19486-1-git-send-email-yanghy@cn.fujitsu.com> <1432116090-19486-5-git-send-email-yanghy@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1432116090-19486-5-git-send-email-yanghy@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Hongyang Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca List-Id: xen-devel@lists.xenproject.org On Wed, 2015-05-20 at 18:01 +0800, Yang Hongyang wrote: > move toolstack code into libxl_toolstack.c It's not clear to me what "toolstack code" is here, the whole of libxl and xl is "toolstack code". Is the code being moved stuff to do with adding toolstack state to the save stream? Perhaps libxl_{suspend,save}_toolstack.c? Or could this not go in the libxl_dom_suspend.c you just created?