From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v1 4/5] tools/libxl: move toolstack code
 into libxl_toolstack.c
Date: Wed, 3 Jun 2015 10:24:46 +0100
Message-ID: <1433323486.7108.32.camel@citrix.com>
References: <1432116090-19486-1-git-send-email-yanghy@cn.fujitsu.com>
	<1432116090-19486-5-git-send-email-yanghy@cn.fujitsu.com>
	<1433256512.15036.296.camel@citrix.com>
	<556DD841.5030609@cn.fujitsu.com> <556E6BD7.3070803@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <556E6BD7.3070803@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-06-03 at 10:52 +0800, Yang Hongyang wrote:
> 
> On 06/03/2015 12:22 AM, Yang Hongyang wrote:
> >
> >
> > On 06/02/2015 10:48 PM, Ian Campbell wrote:
> >> On Wed, 2015-05-20 at 18:01 +0800, Yang Hongyang wrote:
> >>> move toolstack code into libxl_toolstack.c
> >>
> >> It's not clear to me what "toolstack code" is here, the whole of libxl
> >> and xl is "toolstack code".
> >>
> >> Is the code being moved stuff to do with adding toolstack state to the
> >> save stream? Perhaps libxl_{suspend,save}_toolstack.c? Or could this not
> >> go in the libxl_dom_suspend.c you just created?
> >
> > My thought was libxl_dom_suspend.c only contains code that do vm suspend
> > stuff(not save). So compare to move it to dom_suspend.c, I prefer not
> > move it or use libxl_{suspend,save}_toolstack.c. Maybe leave the code
> > not moved?
> 
> I think I'm going to move this code into libxl_dom_save.c, by merge this
> patch with the next patch.

OK.