From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 1/2] libxl: remove code in stubdom creation failure path and callback
Date: Wed, 3 Jun 2015 11:35:39 +0100 [thread overview]
Message-ID: <1433327739.7108.64.camel@citrix.com> (raw)
In-Reply-To: <1433179476-16642-2-git-send-email-wei.liu2@citrix.com>
On Mon, 2015-06-01 at 18:24 +0100, Wei Liu wrote:
> The snippet to destroy stubdom and the callback were added in 1fc3aeb3
> ("libxl: use new QEMU xenstore protocol"). The intention was to destroy
> stubdom when it is not responsive. That approach is problematic because
> rc is not propagate back to sdss->callback, hence the guest is leaked.
>
> The solution is simple. The destruction of stubdom can be done later in
> sdss->callback. That code path already does the right thing to destroy
> both the guest and the stubdom that serves the guest.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked + applied, thanks,
next prev parent reply other threads:[~2015-06-03 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 17:24 [PATCH 0/2] Two stubdom patches Wei Liu
2015-06-01 17:24 ` [PATCH 1/2] libxl: remove code in stubdom creation failure path and callback Wei Liu
2015-06-03 10:35 ` Ian Campbell [this message]
2015-06-01 17:24 ` [PATCH 2/2] libxl: clean up qemu-save and qemu-resume files Wei Liu
2015-06-03 9:58 ` Ian Campbell
2015-06-03 10:11 ` Wei Liu
2015-06-03 10:22 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433327739.7108.64.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).