From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 1/2] libxl: remove code in stubdom creation failure path and callback Date: Wed, 3 Jun 2015 11:35:39 +0100 Message-ID: <1433327739.7108.64.camel@citrix.com> References: <1433179476-16642-1-git-send-email-wei.liu2@citrix.com> <1433179476-16642-2-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z061V-0007le-5e for xen-devel@lists.xenproject.org; Wed, 03 Jun 2015 10:35:49 +0000 In-Reply-To: <1433179476-16642-2-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Xen-devel , Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Mon, 2015-06-01 at 18:24 +0100, Wei Liu wrote: > The snippet to destroy stubdom and the callback were added in 1fc3aeb3 > ("libxl: use new QEMU xenstore protocol"). The intention was to destroy > stubdom when it is not responsive. That approach is problematic because > rc is not propagate back to sdss->callback, hence the guest is leaked. > > The solution is simple. The destruction of stubdom can be done later in > sdss->callback. That code path already does the right thing to destroy > both the guest and the stubdom that serves the guest. > > Signed-off-by: Wei Liu Acked + applied, thanks,