From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2] tools: link executables with libtinfo
	explicitly
Date: Wed, 3 Jun 2015 11:35:50 +0100
Message-ID: <1433327750.7108.65.camel@citrix.com>
References: <1433252006-1779-1-git-send-email-daniel.kiper@oracle.com>
	<20150602165824.GZ19403@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=589ea9610=Ian.Campbell@citrix.com>)
	id 1Z061f-0007r8-JD
	for xen-devel@lists.xenproject.org; Wed, 03 Jun 2015 10:35:59 +0000
In-Reply-To: <20150602165824.GZ19403@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, Daniel Kiper <daniel.kiper@oracle.com>, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-06-02 at 17:58 +0100, Wei Liu wrote:
> On Tue, Jun 02, 2015 at 03:33:26PM +0200, Daniel Kiper wrote:
> > binutils 2.22 changed ld default from --copy-dt-needed-entries
> > to -no-copy-dt-needed-entries. This revealed that some objects
> > are linked implicitly with libtinfo and newer ld fails to build
> > relevant executables.

For future reference "relevant executables" would be better as a list of
the actual affected programs...

> > 
> > Below is short explanation why we should not do that...
> > 
> > http://fedoraproject.org/wiki/UnderstandingDSOLinkChange says:
> > 
> > The default behaviour for ld (my note: before version 2.22) allows
> > users to 'indirectly' link to required objects/libraries through
> > intermediate objects/libraries. While this is convenient, it can
> > also be dangerous because it makes your program's dependencies tied
> > to the dependencies of other objects. If those objects ever change
> > their linkages, they can break your program without any changes
> > to your own code!
> > 
> > Please run autoconf in tools directory.
> > 
> > Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Applied, running autoconf.

Ian.