From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH RFC tools 5/6] tools: Refactor
 /dev/xen/evtchn wrappers into libxenevtchn.
Date: Thu, 11 Jun 2015 09:58:28 +0100
Message-ID: <1434013108.30003.129.camel@citrix.com>
References: <1433936188.30003.60.camel@citrix.com>
	<1433936205-21539-5-git-send-email-ian.campbell@citrix.com>
	<55786607.4020000@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55786607.4020000@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: wei.liu2@citrix.com, roger.pau@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-06-10 at 17:29 +0100, David Vrabel wrote:
> On 10/06/15 12:36, Ian Campbell wrote:
> > libxenevtchn will provide a stable API and ABI for accessing the
> > evtchn device.
> > 
> > The functions are moved into the xenevtchn namespace to make a clean
> > break from libxc and avoid ambiguity regarding which interfaces are
> > stable.
> > 
> > All in-tree users are updated to use the new names.
> > 
> > Upon request (via #define XC_WANT_COMPAT_EVTCHN_API) libxenctrl will
> > provide a compat API for the old names, which is used by qemu-xen for
> > the time being.
> > 
> > The dynamic osdep mechanism from libxc is not preserved, the
> > alternative backend (a xen-api/xapi shim) is no longer around. (Nested
> > virt probably suffices for this use case now).
> > 
> > This leaves a few event channel related functions which go via privcmd
> > (EVTCHNOP) rather than ioctls on the /dev/xen/evtchn device in
> > libxenctrl. Specifically:
> > 
> >  - xc_evtchn_alloc_unbound
> 
> I was about to complain that this is important functionality for this
> new lib, but the library provides the more useful
> xenevtchn_bind_unbound_port() instead.  Might be worth mentioning this
> in the commit.

Yes, I hadn't realised the two were redundant in that way. I'll mention
it.

Perhaps we should even consider removing xc_evtchn_alloc_unbound? Other
then the language bindings I can't see an in tree user apart from the
language bindings. I suspect the user was xend.

Ian.