From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST Nested PATCH v11 6/7] Compose the main
 recipe of nested test job
Date: Wed, 17 Jun 2015 12:48:38 +0100
Message-ID: <1434541718.13744.339.camel@citrix.com>
References: <1432631304-27347-1-git-send-email-longtaox.pang@intel.com>
	<1432631304-27347-7-git-send-email-longtaox.pang@intel.com>
	<21880.23264.813171.606123@mariner.uk.xensource.com>
	<86C3224E41A7434B904EC364302132D80E4BFEC4@SHSMSX101.ccr.corp.intel.com>
	<21881.42757.84361.654532@mariner.uk.xensource.com>
	<86C3224E41A7434B904EC364302132D80E4C0A6B@SHSMSX101.ccr.corp.intel.com>
	<21882.64076.306554.733060@mariner.uk.xensource.com>
	<1434286285.25577.6.camel@localhost>
	<1434359303.13744.16.camel@citrix.com>
	<86C3224E41A7434B904EC364302132D80E4C30D5@SHSMSX101.ccr.corp.intel.com>
	<1434533714.13744.279.camel@citrix.com>
	<86C3224E41A7434B904EC364302132D80E4C3355@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <86C3224E41A7434B904EC364302132D80E4C3355@SHSMSX101.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Pang, LongtaoX" <longtaox.pang@intel.com>
Cc: "Hu, Robert" <robert.hu@intel.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, "wei.liu2@citrix.com" <wei.liu2@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-06-17 at 11:00 +0000, Pang, LongtaoX wrote:
> > > 2015-06-17 08:10:26 Z executing ssh ... root@192.168.199.25 find /tmp /var/run
> > /var/tmp /var/lib/xen /var/core ! -type d -print0 -ls -printf '\0'
> > > find: `/var/core': No such file or directory
> > 
> > /var/core is created by ts-host-install. I think the tail end of the
> > function sub in there which does that and populates /etc/sysctl.conf
> > and /etc/security/limits.d/coredumps.conf should be refactored probably
> > to be alongside the osstest-confirm-booted thing which IIRC you are
> > already going to refactor in the next version.
> > 
> I reviewed related code in 'ts-host-install'. But I am not very clear, the below code will be executed 
> in 'ts-debian-hvm-install' too? Or refactor 'osstest-confirm-booted' and the below action should be finished inside this shell script? 
> Since, it need '/var/core' directory in L1, please correct me.

I think you've already arranged for the osstest-confirm-booted stuff to
happen for the L1 host too, but that Ian J has requested it be done
differently such that it is not duplicated in two places.

The code to setup /var/core and the associated sysctl.conf and limits.d
changes should be done in the same manner as osstest-confirm-booted
eventually is based on Ian's suggestion, whatever that was.

Ian.