From mboxrd@z Thu Jan 1 00:00:00 1970 From: Feng Wu Subject: [v3 08/15] Suppress posting interrupts when 'SN' is set Date: Wed, 24 Jun 2015 13:18:22 +0800 Message-ID: <1435123109-10481-9-git-send-email-feng.wu@intel.com> References: <1435123109-10481-1-git-send-email-feng.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435123109-10481-1-git-send-email-feng.wu@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: kevin.tian@intel.com, keir@xen.org, george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com, jbeulich@suse.com, yang.z.zhang@intel.com, feng.wu@intel.com List-Id: xen-devel@lists.xenproject.org Currently, we don't support urgent interrupt, all interrupts are recognized as non-urgent interrupt, so we cannot send posted-interrupt when 'SN' is set. Signed-off-by: Feng Wu --- v3: use cmpxchg to test SN/ON and set ON xen/arch/x86/hvm/vmx/vmx.c | 32 ++++++++++++++++++++++++++++---- 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 0837627..b94ef6a 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1686,6 +1686,8 @@ static void __vmx_deliver_posted_interrupt(struct vcpu *v) static void vmx_deliver_posted_intr(struct vcpu *v, u8 vector) { + struct pi_desc old, new, prev; + if ( pi_test_and_set_pir(vector, &v->arch.hvm_vmx.pi_desc) ) return; @@ -1698,13 +1700,35 @@ static void vmx_deliver_posted_intr(struct vcpu *v, u8 vector) */ pi_set_on(&v->arch.hvm_vmx.pi_desc); } - else if ( !pi_test_and_set_on(&v->arch.hvm_vmx.pi_desc) ) + else { + prev.control = 0; + + do { + old.control = v->arch.hvm_vmx.pi_desc.control & + ~(1 << POSTED_INTR_ON | 1 << POSTED_INTR_SN); + new.control = v->arch.hvm_vmx.pi_desc.control | + 1 << POSTED_INTR_ON; + + /* + * Currently, we don't support urgent interrupt, all + * interrupts are recognized as non-urgent interrupt, + * so we cannot send posted-interrupt when 'SN' is set. + * Besides that, if 'ON' is already set, we cannot set + * posted-interrupts as well. + */ + if ( prev.sn || prev.on ) + { + vcpu_kick(v); + return; + } + + prev.control = cmpxchg(&v->arch.hvm_vmx.pi_desc.control, + old.control, new.control); + } while ( prev.control != old.control ); + __vmx_deliver_posted_interrupt(v); - return; } - - vcpu_kick(v); } static void vmx_sync_pir_to_irr(struct vcpu *v) -- 2.1.0