From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com
Subject: Re: [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc
Date: Fri, 26 Jun 2015 16:54:11 +0100 [thread overview]
Message-ID: <1435334051.32500.202.camel@citrix.com> (raw)
In-Reply-To: <1435333389-3694-1-git-send-email-julien.grall@citrix.com>
On Fri, 2015-06-26 at 16:43 +0100, Julien Grall wrote:
> This field have been set but not used since Xen 4.5. Slim down Xen by
> about 4K by removing it.
>
> Also fix comment coding style.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> ---
> xen/arch/arm/irq.c | 7 ++++---
> xen/include/asm-arm/irq.h | 1 -
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
> index 2dd43ee..6bb076e 100644
> --- a/xen/arch/arm/irq.c
> +++ b/xen/arch/arm/irq.c
> @@ -219,10 +219,11 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq)
> desc->handler->end(desc);
>
> set_bit(_IRQ_INPROGRESS, &desc->status);
> - desc->arch.eoi_cpu = smp_processor_id();
>
> - /* the irq cannot be a PPI, we only support delivery of SPIs to
> - * guests */
> + /*
> + * The irq cannot be a PPI, we only support delivery of SPIs to
> + * guests.
Stray tab?
Otherwise LGTM: Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-06-26 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 15:43 [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc Julien Grall
2015-06-26 15:54 ` Ian Campbell [this message]
2015-06-26 15:57 ` Julien Grall
2015-06-26 16:04 ` Ian Campbell
2015-06-26 18:15 ` Julien Grall
2015-07-03 15:34 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435334051.32500.202.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).