Re: [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS commands support

[Ian Campbell <ian.campbell@citrix.com>]

On Mon, 2015-06-22 at 17:31 +0530, vijay.kilari@gmail.com wrote:
> +static int vgic_its_process_mapvi(struct vcpu *v, struct vgic_its *vits,
> +                                  its_cmd_block *virt_cmd)
> +{
> +    struct vitt entry;
> +    struct vits_device *vdev;
> +    uint8_t vcol_id, cmd;
> +    uint32_t vid, dev_id, event;
> +
> +    vcol_id = virt_cmd->mapvi.col;
> +    vid = virt_cmd->mapvi.phy_id;
> +    dev_id = its_decode_devid(v->domain, virt_cmd);

If you used the "union its_cmd" I proposed earlier for the virt_cmd
argument then this would just be "virt_command->mapvi.devid".

[...]

> +static int vgic_its_parse_its_command(struct vcpu *v, struct vgic_its *vits,
> +                                      its_cmd_block *virt_cmd)
> +{
> +    uint8_t cmd = its_decode_cmd(virt_cmd);

and this would be cirt_cmd->hdr.cmd.

[...]
> +    memcpy(virt_cmd, p + offset, sizeof(its_cmd_block));

and this would be
	memcpy(&virt_cmd.bits[0], p+offset, sizeof(union its_cmd));

Ian.